Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update "black" dependency as it was breaking on its own dependencies #200

Merged
merged 4 commits into from May 13, 2022

Conversation

imrehg
Copy link
Member

@imrehg imrehg commented May 4, 2022

@imrehg imrehg requested a review from acroz May 4, 2022 12:05
@imrehg imrehg requested review from tommilata and zblz May 13, 2022 06:44
@imrehg imrehg mentioned this pull request May 13, 2022
pyproject.toml Outdated Show resolved Hide resolved
@acroz
Copy link
Member

acroz commented May 13, 2022

LGTM. I've happy to merge once Liam's query is resolved (I am personally unopinionated on whether we include the build-system config or not - we are currently just using setup.py to build as he said).

@imrehg
Copy link
Member Author

imrehg commented May 13, 2022

@acroz resolved for now (I have slight favor for keeping it in, but not enough support for needing it, so removed for now). Thank you!

@acroz acroz merged commit 5f480a7 into facultyai:master May 13, 2022
@imrehg imrehg deleted the black-fixes branch May 15, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants