Black update, updating Python versions, setuptools_scm recommendations #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relevant issue: psf/black#2634
Keep it in tox though, as we cannot automatically test, but could test manually.
Should Python 2.7 and 3.5 be completely dropped from this library as well, then? |
imrehg
changed the title
Same Python versions as thats the core dependency.
imrehg
changed the title
|
LGTM, pending tests being fixed. You could also consider removing the |
Currently not needed as setup.py is used for all those parts.
|
@acroz done the changes you mentioned, good shout! Let me know if anything else needs changing. |
|
@imrehg Can probably update the I also realised that you can remove the universal wheel setting from |
|
@acroz ah, good shout on that, removed, and bumped, all in the clear now. |
acroz
approved these changes
May 17, 2022
|
Thanks, released as 0.14.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
faculty(see in setup)setuptools_scmrecommendations from https://github.com/pypa/setuptools_scm#pyprojecttoml-usage and this change should have no user-facing difference in practiceTests outcome depends on facultyai/faculty#201 being released.