#2868: fix code smell issues

factcast · May 13, 2024 · 6f69ffc · 6f69ffc
1 parent 900e1ff
commit 6f69ffc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/factcast-client-grpc/src/main/java/org/factcast/client/grpc/GrpcFactStore.java b/factcast-client-grpc/src/main/java/org/factcast/client/grpc/GrpcFactStore.java
@@ -567,7 +567,6 @@ public Optional<Fact> fetchBySerial(long serial) {
         () -> converter.fromProto(blockingStub.fetchBySerial(converter.toProto(serial))));
   }
 
-  @VisibleForTesting
   void reset() {
     // marks factstore as not initialized, so that a subsequent call needs to go through handshake
     // first. This is used to signal a faulty connection.

diff --git a/...-client-grpc/src/test/java/org/factcast/client/grpc/FactCastGrpcStubsFactoryImplTest.java b/...-client-grpc/src/test/java/org/factcast/client/grpc/FactCastGrpcStubsFactoryImplTest.java
@@ -34,7 +34,7 @@ class FactCastGrpcStubsFactoryImplTest {
   final FactCastGrpcStubsFactory uut = new FactCastGrpcStubsFactoryImpl();
 
   @Test
-  public void createsBlockingStub() {
+  void createsBlockingStub() {
     try (MockedStatic<RemoteFactStoreGrpc> mock = mockStatic(RemoteFactStoreGrpc.class)) {
       RemoteFactStoreGrpc.RemoteFactStoreBlockingStub stub =
           mock(RemoteFactStoreGrpc.RemoteFactStoreBlockingStub.class);
@@ -44,7 +44,7 @@ public void createsBlockingStub() {
   }
 
   @Test
-  public void createsStub() {
+  void createsStub() {
     try (MockedStatic<RemoteFactStoreGrpc> mock = mockStatic(RemoteFactStoreGrpc.class)) {
       RemoteFactStoreGrpc.RemoteFactStoreStub stub =
           mock(RemoteFactStoreGrpc.RemoteFactStoreStub.class);