Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.yml #222

Closed
wants to merge 1 commit into from
Closed

build.yml #222

wants to merge 1 commit into from

Conversation

cclauss
Copy link

@cclauss cclauss commented Aug 29, 2021

Upgrade to actions/setup-python@v2 and use TOXENV=py, not py3x as discussed at
https://docs.github.com/en/actions/guides/building-and-testing-python#running-tests-with-tox

Upgrade to actions/setup-python@v2 and use TOXENV=py, not py3x as discussed at https://docs.github.com/en/actions/guides/building-and-testing-python#running-tests-with-tox
@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: infrastructure Related to project infrastructure. labels Aug 29, 2021
@facelessuser
Copy link
Owner

You can upgrade to V2 but please do not change the TOXENV. That variable is used to distinguish between which run is which and then to setup the other build variables based on the current running test.

The docs may suggest to use py, but that does not mean that we are doing anything incorrect, just different.

@facelessuser
Copy link
Owner

In doing this, I'd prefer it is done in not only build.yml but also deploy.yml. I've made the change in #223 as it is a very easy change. It should upgrade the dependency as requested and resolve this request as well. Thank you for alerting us to the fact that setup-python@v2 is available!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: infrastructure Related to project infrastructure. S: needs-review Needs to be reviewed and/or approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants