This repository has been archived by the owner on Apr 2, 2021. It is now read-only.
Fix crash on iOS when passing null values to setUserData
#626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any value passed to
setUserData
is null it causes a crash on iOS. This is because the fbsdk expects nil and not NSNull. To fix it we pass all values throughRCTNilIfNull
.Test Plan:
Test that
setUserData({email: null})
doesn't crash anymore.