Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export Env::default() #7207

Closed
wants to merge 1 commit into from
Closed

feat: export Env::default() #7207

wants to merge 1 commit into from

Conversation

developerfred
Copy link
Contributor

I need this exported function to disable threads in rust.

rust-rocksdb/rust-rocksdb#448 (comment)

@developerfred developerfred mentioned this pull request Jul 30, 2020
Merged
4 tasks
@developerfred developerfred force-pushed the export-env-default branch 2 times, most recently from 45a78f3 to ce32ece Compare July 30, 2020 20:55
mrambacher
mrambacher reviewed Jul 30, 2020
View reviewed changes
Copy link
Contributor

@mrambacher mrambacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please better explain what you are trying to do here? Are you trying to get the default environment or something else? Is there a reason "rocksdb_create_default_env" does not work for your use case?

I am not sure I understand exactly what this code is doing or you hope to accomplish.

@developerfred
Copy link
Contributor Author

developerfred commented Jul 30, 2020 •
edited

Can you please better explain what you are trying to do here? Are you trying to get the default environment or something else? Is there a reason "rocksdb_create_default_env" does not work for your use case?

I am not sure I understand exactly what this code is doing or you hope to accomplish.

@mrambacher
I need to disable the threads by default, currently the default that we consume returns an object you can learn more in this chat link
rust-rocksdb/rust-rocksdb#448 (comment)

@developerfred developerfred deleted the export-env-default branch August 7, 2020 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrambacher mrambacher Awaiting requested review from mrambacher

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@developerfred @mrambacher @facebook-github-bot