Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export SetBackgroundThreads(n, Env::BOTTOM); #7191

Conversation

developerfred
Copy link
Contributor

@developerfred developerfred force-pushed the export-rocksdb_env_set_bacground_threads_disable branch from e5269d6 to f900f6b Compare July 28, 2020 21:56
Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@developerfred developerfred force-pushed the export-rocksdb_env_set_bacground_threads_disable branch from 19180d5 to b614bdb Compare July 29, 2020 14:20
@facebook-github-bot
Copy link
Contributor

@developerfred has updated the pull request. You must reimport the pull request before landing.

@developerfred developerfred force-pushed the export-rocksdb_env_set_bacground_threads_disable branch from b614bdb to 099a283 Compare July 29, 2020 14:28
@facebook-github-bot
Copy link
Contributor

@developerfred has updated the pull request. You must reimport the pull request before landing.

@developerfred developerfred force-pushed the export-rocksdb_env_set_bacground_threads_disable branch from 099a283 to efe03aa Compare July 29, 2020 14:33
@facebook-github-bot
Copy link
Contributor

@developerfred has updated the pull request. You must reimport the pull request before landing.

@developerfred developerfred force-pushed the export-rocksdb_env_set_bacground_threads_disable branch from efe03aa to e1d4a84 Compare July 29, 2020 14:37
@facebook-github-bot
Copy link
Contributor

@developerfred has updated the pull request. You must reimport the pull request before landing.

@developerfred
Copy link
Contributor Author

@facebook-github-bot I ran the clang-format in my code

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ajkr merged this pull request in 50f206a.

@facebook-github-bot
Copy link
Contributor

@ajkr merged this pull request in 50f206a.

@developerfred developerfred deleted the export-rocksdb_env_set_bacground_threads_disable branch July 30, 2020 17:43
codingrhythm pushed a commit to SafetyCulture/rocksdb that referenced this pull request Mar 5, 2021
Summary:
- rust-rocksdb/rust-rocksdb#448

Pull Request resolved: facebook#7191

Reviewed By: riversand963

Differential Revision: D22809066

Pulled By: ajkr

fbshipit-source-id: 036939f9a28cacc3f677c318d1aed97fe5f4f85e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants