Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export stats_persist_period_sec #7168

Closed
wants to merge 2 commits into from
Closed

export stats_persist_period_sec #7168

wants to merge 2 commits into from

Conversation

developerfred
Copy link
Contributor

@developerfred developerfred commented Jul 23, 2020 •
edited

@developerfred developerfred mentioned this pull request Jul 23, 2020
Merged
4 tasks
@stanislav-tkach
Copy link
Contributor

You should add an implementation for these functions in the db/c.cc file and probably tests in the db/c_test.c file.

@developerfred
Copy link
Contributor Author

developerfred commented Jul 24, 2020 •
edited

You should add an implementation for these functions in the db/c.cc file and probably tests in the db/c_test.c file.

@DarkEld3r Thanks I will do!

@developerfred developerfred force-pushed the export-stats_persist_period_sec branch 8 times, most recently from de8d123 to 1401c23 Compare July 24, 2020 18:03
stanislav-tkach
stanislav-tkach reviewed Jul 24, 2020
View reviewed changes
db/c_test.c Outdated Show resolved Hide resolved
@developerfred developerfred force-pushed the export-stats_persist_period_sec branch from 1401c23 to 9bf25e6 Compare July 24, 2020 19:33
facebook-github-bot
facebook-github-bot reviewed Jul 24, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ajkr
ajkr approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@facebook-github-bot
Copy link
Contributor

@ajkr merged this pull request in 83ea266.

@developerfred developerfred deleted the export-stats_persist_period_sec branch July 30, 2020 17:43
codingrhythm pushed a commit to SafetyCulture/rocksdb that referenced this pull request Mar 5, 2021
@developerfred @codingrhythm
export stats_persist_period_sec (facebook#7168)
bc7eadf 
Summary:
fixed
 - rust-rocksdb/rust-rocksdb#447
 -  rust-rocksdb/rust-rocksdb#448

Pull Request resolved: facebook#7168

Reviewed By: cheng-chang

Differential Revision: D22736013

Pulled By: ajkr

fbshipit-source-id: fdd784aa75d26a367b9108b05ffdd94a2ae117d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanislav-tkach stanislav-tkach stanislav-tkach left review comments

@facebook-github-bot facebook-github-bot Awaiting requested review from facebook-github-bot

@ajkr ajkr Awaiting requested review from ajkr

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@developerfred @stanislav-tkach @facebook-github-bot @ajkr