Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable file deletion before GetLiveFilesStorageInfo() in stress test #12629

Closed
wants to merge 1 commit into from

Conversation

hx235
Copy link
Contributor

@hx235 hx235 commented May 8, 2024

Context/Summary:
According to below API, we need to disable/enable file deletion when testing GetLiveFilesStorageInfo() in crash test.

...
If creating a live copy, use DisableFileDeletions() before and EnableFileDeletions() after to prevent deletions.
...
  virtual Status GetLiveFilesStorageInfo(
...

Otherwise we can run into failures like

Verification failed: VerifyGetLiveFilesStorageInfo failed: IO error: No such file or directory: while stat a file for size: /dev/shm/rocksdb_test/rocksdb_crashtest_blackbox/027550.log: No such file or directory

Test:
CI

@facebook-github-bot
Copy link
Contributor

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@hx235 hx235 requested review from jaykorean and pdillinger May 8, 2024 22:42
@ajkr
Copy link
Contributor

ajkr commented May 9, 2024

If creating a live copy, use DisableFileDeletions() before and EnableFileDeletions() after to prevent deletions.

VerifyGetLiveFilesStorageInfo() doesn't create a live copy. Should GetLiveFilesStorageInfo() call DisableFileDeletions() and EnableFileDeletions() internally?

@hx235 hx235 closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants