Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post for 15.6.0 #9950

Merged
merged 4 commits into from Jun 13, 2017
Merged

Conversation

flarnie
Copy link
Contributor

@flarnie flarnie commented Jun 13, 2017

what is the change?:
A short and sweet summary of 15.6.0 changes

why make this change?:
To thank community contributors and call out important changes.

test plan:
Visual inspection.
I also looked it over in a markdown viewer - http://dillinger.io/

screen shot 2017-06-13 at 1 57 51 pm
screen shot 2017-06-13 at 1 58 00 pm
screen shot 2017-06-13 at 1 58 10 pm

issue:
#9398

**what is the change?:**
A short and sweet summary of 15.6.0 changes

**why make this change?:**
To thank community contributors and call out important changes.

**test plan:**
Visual inspection.
I also looked it over in a markdown viewer - http://dillinger.io/

**issue:**
facebook#9398
@flarnie
Copy link
Contributor Author

flarnie commented Jun 13, 2017

just noticed I need to add the customary 'Installation' and 'changelog' sections. Will do that now.

**what is the change?:**
Added the 'Installation' section we have on most release blog posts,
customized for the 15.6.0 version of React.
Added the 'Changelog' from master to the blog post.

**why make this change?:**
To show folks how to install React and what changes are in this release.

**test plan:**
Visual inspection

**issue:**
facebook#9398
---
title: "React v15.6.0"
author: flarnie
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll need to add yourself to https://github.com/facebook/react/blob/master/docs/_data/authors.yml for this to become a link.

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this for now? I'll add when addons are bumped. Otherwise it's a bit misleading.

@gaearon
Copy link
Collaborator

gaearon commented Jun 13, 2017

Ugh GitHub interface confused me. Last comment refers to "React addons" section.


We recommend using a bundler like [webpack](https://webpack.js.org/) or [Browserify](http://browserify.org/) so you can write modular code and bundle it together into small packages to optimize load time.

Remember that by default, React runs extra checks and provides helpful warnings in development mode. When deploying your app, make sure to [compile it in production mode](/react/docs/installation.html#development-and-production-versions).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this link no longer exists?
Should we instead link to https://facebook.github.io/react/docs/optimizing-performance.html#use-the-production-build

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we should! Good catch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - so maybe we can change it to this:

When deploying your app, make sure to [use the production build](...link to that doc).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works too.

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted with changes requested above:

  • Add yourself to contributors so your name turns into a link
  • Use backticks for code-ish things
  • Second header should be ##, not #
  • Let's change production mode link to the new address per @bvaughn's comment
  • Need to update changelog with fixes from my PR

Otherwise looks great!

We've also published version `15.6.0` of `react` and `react-dom` on npm, and the `react` package on bower.

---

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's roll the updates from #9951 here too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will fix.


Thanks to [Jason Quense](https://github.com/jquense) and everyone who helped out on those issues and PRs.

# Downgrading Deprecation Warnings
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should start with ##. It looks giant compared to other headings otherwise.


## Improving Inputs

In React 15.6.0 the 'onChange' event for inputs is a little bit more reliable and handles more edge cases, including the following:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use backticks, not apostrophes. Backticks appear as code blocks in the post.


We are also including a couple of new warnings for upcoming deprecations. These should not affect most users, and for more details see the changelog below.

After the last release, we got valuable community feedback that deprecation warnings were causing noise and failing tests. **In React 15.6, we have downgraded deprecation warnings to use 'console.warn' instead of 'console.error'.** Our other warnings will still use 'console.error' because they surface urgent issues which could lead to bugs. Unlike our other warnings, deprecation warnings can be fixed over time and won't cause problems in your app if shipped. We believe that downgrading the urgency of deprecation warnings will make your next update easier. Thanks to everyone who was involved in the discussion of this change.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, too, we should use backticks.

**what is the change?:**
- Add self to contributors so my name turns into a link
- Use backticks for code-ish things
- Second header to ##, not #
- Change production mode link to the new address per @bvaughn's comment
- Update changelog with fixes from facebook#9951

**why make this change?:**
Make things more clear and accurate.

**test plan:**
Visual inspect - @flarnie will paste an image of how it appears in the
actual docs.

**issue:**
facebook#9398
In React 15.6.0 the `onChange` event for inputs is a little bit more reliable and handles more edge cases, including the following:

* not firing when radio button is clicked but not changed ([issue 1471](https://github.com/facebook/react/issues/1471))
* changing an input of type 'range' with the arrow keys ([issue 554](https://github.com/facebook/react/issues/554))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backticks


Thanks to [Jason Quense](https://github.com/jquense) and everyone who helped out on those issues and PRs.

## Downgrading Deprecation Warnings
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "downgrading" universally understood in this context? Is there any equivalent way of saying it? "Softening Deprecation Warnings" or something like it. "Downgrading" sounds a bit related to versioning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - not sure about 'Softening' either but will chat with folks and see what we come up with.


We recommend using a bundler like [webpack](https://webpack.js.org/) or [Browserify](http://browserify.org/) so you can write modular code and bundle it together into small packages to optimize load time.

Remember that by default, React runs extra checks and provides helpful warnings in development mode. When deploying your app, make sure to [use the production build](https://facebook.github.io/react/docs/optimizing-performance.html#use-the-production-build).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we don't leave domain in posts in case we change the domain. So the link should start with /react/docs/... instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix.


In case you don't use a bundler, we also provide pre-built bundles in the npm packages which you can [include as script tags](/react/docs/installation.html#using-a-cdn) on your page:

* **React**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you leave two spaces after this line (and similar headers), you'll see newlines in rendered result.
Older posts have two spaces there.

Or you could use <br> to force it explicitly. (Two spaces after the line and <br> are equivalent in Markdown).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!! Thanks, will fix.

**what is the change?:**
- Reword heading about deprecation warning changes
- add 'br' s to the list of installation options
- add some stray missing backticks

**why make this change?:**
Clarity and readability

**test plan:**
Visual inspection

**issue:**
facebook#9398
@flarnie flarnie merged commit ce6108d into facebook:master Jun 13, 2017
flarnie added a commit that referenced this pull request Jun 13, 2017
* Blog post for 15.6.0

**what is the change?:**
A short and sweet summary of 15.6.0 changes

**why make this change?:**
To thank community contributors and call out important changes.

**test plan:**
Visual inspection.
I also looked it over in a markdown viewer - http://dillinger.io/

**issue:**
#9398

* Add 'Installation' and 'Changelog' to 15.6.0 blog post

**what is the change?:**
Added the 'Installation' section we have on most release blog posts,
customized for the 15.6.0 version of React.
Added the 'Changelog' from master to the blog post.

**why make this change?:**
To show folks how to install React and what changes are in this release.

**test plan:**
Visual inspection

**issue:**
#9398

* Improvements to blog post, and add self to `authors.yml`

**what is the change?:**
- Add self to contributors so my name turns into a link
- Use backticks for code-ish things
- Second header to ##, not #
- Change production mode link to the new address per @bvaughn's comment
- Update changelog with fixes from #9951

**why make this change?:**
Make things more clear and accurate.

**test plan:**
Visual inspect - @flarnie will paste an image of how it appears in the
actual docs.

**issue:**
#9398

* Further improvements to 15.6 blog post

**what is the change?:**
- Reword heading about deprecation warning changes
- add 'br' s to the list of installation options
- add some stray missing backticks

**why make this change?:**
Clarity and readability

**test plan:**
Visual inspection

**issue:**
#9398
@flarnie flarnie deleted the addBlogPostFor15.6Release branch May 25, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants