Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update create-react-class package.json to use latest react #9935

Closed
wants to merge 1 commit into from
Closed

update create-react-class package.json to use latest react #9935

wants to merge 1 commit into from

Conversation

elijahsmith
Copy link

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint).
  6. Format your code with prettier (npm run prettier).
  7. Run the Flow typechecks (npm run flow).
  8. If you added or removed any tests, run ./scripts/fiber/record-tests before submitting the pull request, and commit the resulting changes.
  9. If you haven't already, complete the CLA.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@elijahsmith
Copy link
Author

this is an attempt to address #9750.

The issue is that the create-react-class npm package has been built with an old version of React in it, which causes GCC to choke when it tries to compile anything that uses it. I'm not sure how the npm package is generated -- the command isn't in the package.json, for instance -- but this PR updates the versions of the react packages that are referenced in the package.json.

I'm not sure what needs to happen with the yarn.lock file -- should I update that as well?

@gaearon
Copy link
Collaborator

gaearon commented Jun 12, 2017

I believe I fixed this in #9933.

@gaearon gaearon closed this Jun 12, 2017
@elijahsmith
Copy link
Author

I saw that -- I wasn't convinced that would address the issue but I'm hoping I'm wrong.

To find out -- can you please republish the create-react-class npm package with these changes in it?

@gaearon
Copy link
Collaborator

gaearon commented Jun 12, 2017

Not yet. We'll publish it soon after 15.6. If something's missing by then I'm happy to follow up.

I'm pretty sure this will address the issue though. (The addon is using a copy of that code, changing it in React or bumping React package will have no effect.)

@elijahsmith
Copy link
Author

ok thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants