Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @nosideeffects from create-react-class #9928

Conversation

tupton
Copy link

@tupton tupton commented Jun 12, 2017

Fixes the remaining issue with @nosideeffects and the create-react-class addon, as mentioned in #7551 (context.)

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint).
  6. Format your code with prettier (npm run prettier).
  7. Run the Flow typechecks (npm run flow).
  8. If you added or removed any tests, run ./scripts/fiber/record-tests before submitting the pull request, and commit the resulting changes.
  9. If you haven't already, complete the CLA.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Collaborator

gaearon commented Jun 12, 2017

Please send this against 15.6-dev instead. Thanks!

@gaearon
Copy link
Collaborator

gaearon commented Jun 12, 2017

Closing in favor of #9933 (against the correct branch), thanks for raising awareness though.

@gaearon gaearon closed this Jun 12, 2017
@tupton tupton deleted the remove-@nosideeffects-create-react-class branch June 12, 2017 19:27
@gaearon
Copy link
Collaborator

gaearon commented Jun 13, 2017

This should be fixed in create-react-class@15.6.0-rc.0. Please verify, it will become 15.6.0 tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants