Remove stray reference to React.PropTypes in ReactLink #9757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**what is the change?:** It looks like we missed updating this callsite in facebook@12a96b9 **why make this change?:** We are deprecating the `React.PropTypes` syntax and splitting that functionality into [a separate module](facebook@12a96b9). @acdlite please correct me if there is a reason we left this here. **test plan:** `yarn test` **issue:** facebook#9755
sophiebits
approved these changes
May 23, 2017
|
Indeed, ReactLink itself is also deprecated. https://facebook.github.io/react/blog/#discontinuing-support-for-react-addons |
flarnie
added a commit
to flarnie/react
that referenced
this pull request
Jun 7, 2017
**what is the change?:** It looks like we missed updating this callsite in facebook@12a96b9 **why make this change?:** We are deprecating the `React.PropTypes` syntax and splitting that functionality into [a separate module](facebook@12a96b9). @acdlite please correct me if there is a reason we left this here. **test plan:** `yarn test` **issue:** facebook#9755
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is the change?:
It looks like we missed updating this callsite in 12a96b9
why make this change?:
We are deprecating the
React.PropTypessyntax and splitting that functionality into a separate module.@acdlite please correct me if there is a reason we left this here.
test plan:
yarn testissue:
fixes #9755