Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove loose check on non-number controlled inputs. Fix trailing dot issue. #9584

Merged
merged 3 commits into from May 3, 2017

Commits on May 2, 2017

  1. Remove loose check when assigning non-number inputs

    This commit removes a check I added when working on number input
    issues where we perform a loose check on an input's value before we
    assign it. This prevented controlled text inputs from disallowing
    numeric text entry.
    
    I also added a DOM fixture text case.
    
    Related issues:
    
    facebook#9561 (comment)
    nhunzaker committed May 2, 2017
    Copy the full SHA
    0df1709 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2017

  1. Use strict equality as a guard before assigning input.value

    This commit adds back the guard around assigning the value property to
    an input, however it does it using a strict equals. This prevents
    validated inputs, like emails and urls from losing the cursor
    position.
    
    It also adds associated test fixtures.
    nhunzaker committed May 3, 2017
    Copy the full SHA
    3e1a768 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    d421181 View commit details
    Browse the repository at this point in the history