Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Changelog for v15.5.1-15.5.4 #9537

Merged
merged 4 commits into from
May 1, 2017
Merged

Update Changelog for v15.5.1-15.5.4 #9537

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89ce543
Update Changelog for v15.5.1-15.5.4
flarnie Apr 26, 2017
c4d1a20
Further improve CHANGELOG entries for v15.5.1-15.5.4
flarnie Apr 27, 2017
a6534a6
Fix final nits in CHANGELOG
flarnie Apr 28, 2017
c414e77
Add deprecation notice to v15.5.0-15.5.3
flarnie May 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
59 changes: 59 additions & 0 deletions ADD-ONS-CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
# React Add-Ons Change Log
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to have this file long term? Since these are final versions ever (hopefully), it seems a bit redundant to add a new file that we’ll never change, for parts that were technically discontinued. Maybe we could put this up as a gist instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good - will move it to a gist.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let’s just keep it in the main changelog? It seems like they could fit in fine if grouped under React Addons for each release (see like we did before).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on later comments, will move this inline to the main Changelog.


As of React v15.5.0 we discontinued active maintenance of the React Addons
packages. In previous versions of React we kept the version numbers of
these packages in sync with the React version, and included updates to
them in the main React `CHANGELOG.md`.

Since the release versions of these packages are now out of sync with React,
and we are no longer including them as a supported part of React, we have split
out the latest changes into this separate change log.

## Create Fragment

### 15.5.3

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general we avoid deeply technical descriptions of changes.
I would prefer that instead of "envify and collapse" we would say something like

  • Fixed the accidental size regression in UMD bundles.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaah nice - that is a simpler way of saying it. Will fix.

* Fix react-addons-create-fragment package to export correct thing. [See #9383](https://github.com/facebook/react/pull/9383).
* Envify and collapse create-fragment UMD. [See #9383](https://github.com/facebook/react/pull/9383).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This points to the same PR as above. Mistake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good of you to notice, and yes it's intentional. A bunch of these changes were made in PR 9383.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they were actually made in PR #9385 though, not PR #9383

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right - thanks again for flagging!


## Create-React-Class

### 15.5.2

* Fix devDeps. [See #9383](https://github.com/facebook/react/pull/9383).
* Add missing object-assign dependency. [See #9383](https://github.com/facebook/react/pull/9383).
* Envify and collapse create-react-class UMD. [See #9383](https://github.com/facebook/react/pull/9383).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually these all point to the same PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think maybe you meant to link multiple bullets to PR #9385?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that - also going to update this to use the '[@author] in [#PR/commit]' format.


## CSS Transition Group & Transition Group

## Linked State Mixin

### 15.5.2

* Envify and collapse LinkedStateMixin UMD. [See #9383](https://github.com/facebook/react/pull/9383).

## Linked Input

### 15.5.1

* Remove unused prop-types dep. [See #9383](https://github.com/facebook/react/pull/9383).
* Fix change handling. [See #9383](https://github.com/facebook/react/pull/9383).
* Fix and collapse LinkedInput UMD. [See #9383](https://github.com/facebook/react/pull/9383).

## Pure Render Mixin

### 15.5.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this one 15.5.2 and Test Utils has 15.5.1? (Can't tell if either is significant, honestly.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to figure out either what version a change was released in, or at least what the latest version of each package is. The latest version of each of these is 15.5.2 and 15.5.1 respectively.

* No significant changes

## Shallow Compare

### 15.5.2

* Uninline shallowEqual in shallowCompare. [See #9385](https://github.com/facebook/react/pull/9385).

## Test Utils

### 15.5.1

* No significant changes

18 changes: 18 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,21 @@
## 15.5.4 (April 11, 2017)

* Fix compatibility with Enzyme by exposing `batchedUpdates` on shallow renderer. [See #9382](https://github.com/facebook/react/commit/69933e25c37cf5453a9ef132177241203ee8d2fd).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, we try to separate React, React DOM, and React Test Renderer changes.
Can we make it clearer which package each change corresponds to?

I also think it might be simpler to roll addon updates right into this list, and summarize them as React Addons bullet point list for each version instead of giving each addon a section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure - maybe that will be less confusing after all. Although then it's a bit tricky to map the add-on version to the React version. I guess I would annotate them in the section where React was using that version of the add-on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also will update all these to use the '[@author] in [#PR/commit]' format.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we'll fix up the link format here too to match others.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - missed that one. Will fix.

* Updates to add-ons - [see add-ons changelog](https://github.com/facebook/react/blob/master/ADD-ONS-CHANGELOG.md).

## 15.5.3 (April 7, 2017)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK versions before 15.5.4 are using prop-types < 15.5.7 in the UMD, thus having the same critical issue. So we should make it clear all of them are effectively deprecated, and people should skip 15.5.0 to 15.5.3, and use at least 15.5.4.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - for now I'll add the same disclaimer from the 'prop-types' repo. Was also thinking of adding the 'yanked' annotation but since that would be a new convention will propose it in a follow-up PR.


* Updates to add-ons - [see add-ons changelog](https://github.com/facebook/react/blob/master/ADD-ONS-CHANGELOG.md).

## 15.5.2 (April 7, 2017)

* Updates to add-ons - [see add-ons changelog](https://github.com/facebook/react/blob/master/ADD-ONS-CHANGELOG.md).

## 15.5.1 (April 7, 2017)

* Fix erroneous PropTypes access warning ([see this commit](https://github.com/facebook/react/commit/ec97ebbe7f15b58ae2f1323df39d06f119873344))
* Fix bug in `prop-types` - [see PropTypes changelog](https://github.com/reactjs/prop-types/blob/master/CHANGELOG.md).

## 15.5.0 (April 7, 2017)

### React
Expand Down