Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Unreleased' section to changelog; update 'contributing' docs #9532

Closed
wants to merge 3 commits into from
Closed

Add 'Unreleased' section to changelog; update 'contributing' docs #9532

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a60199
Add 'Unreleased' section to changelog; update 'contributing' docs
flarnie Apr 26, 2017
7cdf63a
Update numbered list in 'how to contribute' docs
flarnie Apr 26, 2017
2c63039
Wrap 'unreleased' CHANGELOG items in 'details' tag
flarnie Apr 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
@@ -1,4 +1,8 @@
## [Unreleased]
<details>
<summary>Changes that have landed in master but are not yet released.</summary>
Nothing yet! TODO: backfill this section.
</details>

## 15.5.0 (April 7, 2017)

Expand Down
12 changes: 6 additions & 6 deletions docs/contributing/how-to-contribute.md
View file
Open in desktop
Expand Up @@ -80,12 +80,12 @@ The core team is monitoring for pull requests. We will review your pull request
2. If you've added code that should be tested, add tests!
3. If you've changed APIs, update the documentation.
4. If you have made any significant change then please [add an update to the "Unreleased" section of the change log](https://github.com/facebook/react/blob/master/CHANGELOG.md#unreleased). You may skip this step if you made documentation or dependency updates.
4. Ensure the test suite passes (`npm test`).
5. Make sure your code lints (`npm run lint`).
6. Format your code with [prettier](https://github.com/prettier/prettier) (`npm run prettier`).
7. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`).
8. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes.
9. If you haven't already, complete the CLA.
5. Ensure the test suite passes (`npm test`).
6. Make sure your code lints (`npm run lint`).
7. Format your code with [prettier](https://github.com/prettier/prettier) (`npm run prettier`).
8. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`).
9. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes.
10. If you haven't already, complete the CLA.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we change this we usually also want to change the GitHub pull request template (unless you already have). It's in .github folder.


### Contributor License Agreement (CLA)

Expand Down