Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support iframes (nested browsing contexts) in selection event handling (stale version) #7936

Closed
wants to merge 8 commits into from
Closed

Support iframes (nested browsing contexts) in selection event handling (stale version) #7936

wants to merge 8 commits into from

Commits on Dec 2, 2016

  1. More accurate jsdoc comments

    @acusti
    acusti committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    0a2516b View commit details
    Browse the repository at this point in the history

  2. Avoid global document and window objects, facebook#427

    @acusti
    acusti committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    bd5cb57 View commit details
    Browse the repository at this point in the history

  3. Make getting/setting selection check iframe contents 

    If an input inside a same-domain iframe is the actual activeElement,
this change will make the ReactInputSelection module get from and
restore selection to that input, rather than the iframe element itself
    @acusti
    acusti committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    8ec1ae6 View commit details
    Browse the repository at this point in the history

  4. Use event target doc as getActiveElement context 

    Depends on facebook/fbjs#188
    @acusti
    acusti committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    f95ff15 View commit details
    Browse the repository at this point in the history

  5. Add tests for ReactInputSelection 

    Had to remove some tests because they rely on DOM functionality that
jsdom doesn’t yet support, like getSelection and iframe activeElement
    @acusti
    acusti committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    77e490a View commit details
    Browse the repository at this point in the history

  6. Adapt restoreSelection to work for *all* activeElements

    @acusti
    acusti committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    e948e95 View commit details
    Browse the repository at this point in the history

  7. Tests for getting / restoring selections across iframes

    @acusti
    acusti committed Dec 2, 2016
    Configuration menu
    Copy the full SHA
    b48f472 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2017

  1. Add guards for Firefox and Safari compatibility 

    Addresses
facebook#7936 (comment) and
summernote/summernote#1057
    @acusti
    acusti committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    a97e39c View commit details
    Browse the repository at this point in the history