Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom attributes by default #7311

Closed
wants to merge 22 commits into from
Closed

Allow custom attributes by default #7311

wants to merge 22 commits into from

Commits on Aug 4, 2017

  1. Allow custom attributes. Add flag to toggle custom attribute behavior

    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    afae07c View commit details
    Browse the repository at this point in the history

  2. Update custom attribute logic 

    - Only allow string attributes
- Remove custom attribute feature flag
- Add additional tests for data, aria, and custom attributes
    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    3388f4f View commit details
    Browse the repository at this point in the history

  3. Allow numbers and booleans custom attributes. Cut isCustomAttribute

    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    9f7a696 View commit details
    Browse the repository at this point in the history

  4. Cover objects with custom attributes in warning test

    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    fd94756 View commit details
    Browse the repository at this point in the history

  5. Rename DOMProperty.isWriteable to shouldSetAttribute

    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    f870980 View commit details
    Browse the repository at this point in the history

  6. Rework conditions in shouldSetProperty to avoid edge cases

    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    ab64ef3 View commit details
    Browse the repository at this point in the history

  7. Update unknown property warning to include custom attribute information

    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    7717ed7 View commit details
    Browse the repository at this point in the history

  8. Remove ref and key from reserved props

    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    2b402a4 View commit details
    Browse the repository at this point in the history

  9. Ensure SSR test coverage for DOMProperty injections

    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    1681e7f View commit details
    Browse the repository at this point in the history

  10. Add ajaxify attribute for internal FB support

    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    b5736c7 View commit details
    Browse the repository at this point in the history

  11. Ajaxify is a stringifiable object attribute

    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    976ca82 View commit details
    Browse the repository at this point in the history

  12. Update test name for custom attributes on custom elements

    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    17d3c49 View commit details
    Browse the repository at this point in the history

  13. Remove SSR custom injection test

    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    40dee5a View commit details
    Browse the repository at this point in the history

  14. Remove onAfterResetModules hooks in SSR render tests

    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    b26384d View commit details
    Browse the repository at this point in the history

  15. Do not allow assignment of attributes that are aliased

    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    d672771 View commit details
    Browse the repository at this point in the history

  16. Update custom attribute test to check value, not just presence

    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    a871d55 View commit details
    Browse the repository at this point in the history

  17. Address case where class is assigned as an attribute on custom elemen… 

    …ts. Improve SSR tests
    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    c748e84 View commit details
    Browse the repository at this point in the history

  18. Cover cases where className and for are given to custom elements

    @nhunzaker
    nhunzaker committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    16dd18a View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2017

  1. Remove unnecessary spys on console.error. Reduce extra space in tests

    @nhunzaker
    nhunzaker committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    e68bf4d View commit details
    Browse the repository at this point in the history

  2. Cover cased custom attributes in SSR tests

    @nhunzaker
    nhunzaker committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    83e46aa View commit details
    Browse the repository at this point in the history

  3. Custom attributes are case sensitive

    @nhunzaker
    nhunzaker committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    facfa87 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2017

  1. Allow uppercase letters in custom attributes. Address associated edge… 

    … cases
    @nhunzaker
    nhunzaker committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    82e05e0 View commit details
    Browse the repository at this point in the history