Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test for ignored suppressHydrationWarning using hydrateRoot #25635

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Nov 4, 2022

Failing test for #25627

The question is whether we should duplicate all hydrate tests to also test with hydrateRoot or "just" replace hydrate with hydrateRoot. And then check where hydrateRoot should behave differently than hydrate.

Looked through the React 18 WG and couldn't find mention of changed behavior for suppressHydrationWarning. #24270 makes it sound like suppressHydrationWarning should behave the same.

@sizebot
Copy link

sizebot commented Nov 4, 2022

Comparing: bdd3d08...0cb2202

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 153.13 kB 153.13 kB = 48.84 kB 48.84 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 155.05 kB 155.05 kB = 49.44 kB 49.44 kB
facebook-www/ReactDOM-prod.classic.js = 529.21 kB 529.21 kB = 94.48 kB 94.48 kB
facebook-www/ReactDOM-prod.modern.js = 514.47 kB 514.47 kB = 92.32 kB 92.32 kB
facebook-www/ReactDOMForked-prod.classic.js = 529.21 kB 529.21 kB = 94.49 kB 94.48 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 0cb2202

@eps1lon
Copy link
Collaborator Author

eps1lon commented Feb 27, 2023

Underlying issue was closed with "working as intended"

@eps1lon eps1lon closed this Feb 27, 2023
@eps1lon eps1lon deleted the fix/react-dom-server/suppressHydrationWarning branch February 27, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants