New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid accumulating hydration mismatch errors after the first hydration error #24427
Closed
Commits on Apr 22, 2022
-
Avoid accumulating hydration mismatch errors after the first hydratio…
…n error If there is a suspended component or an error during hydration there will almost certainly be many additional hydration mismatch errors because the hydration target does not pair up the server rendered html with an expected slot on the client. To avoid spamming users with warnings there was already logic in place to suppress console warnings if such an occurrence happens. This commit takes another approach to avoid queueing thrown errors. when suspending this isn't that big of an issue becuase queued errors are discarded becasue the suspense boundary does not complete. When erroring within a resolved suspense boundary however the root completes and all queued errors are upgraded to recoverable errors and in many cases wihll flood the console. What is worse is the console warnings which offer much more specific guidance on what went wrong (in dev) are suppressed so the user is left with very little actionable information on which to go on and the volume of mismatch errors may distract from identifying the root cause error The hueristic is as follows 1. always queue the first error during hydration 2. always queue non hydration mismatch errors 2. discard hydration mismatch errors before queueing If there is an already queued error or any type
Configuration menu - View commit details
-
Copy full SHA for 0f8775a - Browse repository at this point
Copy the full SHA 0f8775aView commit details
Commits on Apr 28, 2022
-
Reduce uncaught errors caused by IGC and refactor mismatch errors to …
…not use error properties
Configuration menu - View commit details
-
Copy full SHA for 72fa9bb - Browse repository at this point
Copy the full SHA 72fa9bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 136a2ac - Browse repository at this point
Copy the full SHA 136a2acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4783e68 - Browse repository at this point
Copy the full SHA 4783e68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3773d00 - Browse repository at this point
Copy the full SHA 3773d00View commit details -
Configuration menu - View commit details
-
Copy full SHA for f15c5f2 - Browse repository at this point
Copy the full SHA f15c5f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9648314 - Browse repository at this point
Copy the full SHA 9648314View commit details -
Configuration menu - View commit details
-
Copy full SHA for f531201 - Browse repository at this point
Copy the full SHA f531201View commit details -
Configuration menu - View commit details
-
Copy full SHA for a84b1ad - Browse repository at this point
Copy the full SHA a84b1adView commit details -
Configuration menu - View commit details
-
Copy full SHA for e74488b - Browse repository at this point
Copy the full SHA e74488bView commit details
Commits on Apr 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 87d8ef5 - Browse repository at this point
Copy the full SHA 87d8ef5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0489ee0 - Browse repository at this point
Copy the full SHA 0489ee0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d016d50 - Browse repository at this point
Copy the full SHA d016d50View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.