Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain the rationale for the chosen escaping implemenation in a comment #24389

Merged
merged 1 commit into from Apr 16, 2022

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented Apr 16, 2022

Clarifies the why of #24385 with an explanatory comment

@sizebot
Copy link

sizebot commented Apr 16, 2022

Comparing: d40dc73...3bca464

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.43 kB 131.43 kB = 42.05 kB 42.05 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.70 kB 136.70 kB = 43.64 kB 43.64 kB
facebook-www/ReactDOM-prod.classic.js = 435.12 kB 435.12 kB = 79.88 kB 79.88 kB
facebook-www/ReactDOM-prod.modern.js = 420.12 kB 420.12 kB = 77.51 kB 77.51 kB
facebook-www/ReactDOMForked-prod.classic.js = 435.12 kB 435.12 kB = 79.88 kB 79.88 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-dom/cjs/react-dom-server.browser.development.js +0.27% 230.46 kB 231.07 kB +0.42% 56.27 kB 56.50 kB
oss-stable/react-dom/cjs/react-dom-server.browser.development.js +0.27% 230.46 kB 231.07 kB +0.42% 56.27 kB 56.50 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.development.js +0.27% 230.82 kB 231.44 kB +0.41% 56.02 kB 56.25 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.development.js +0.27% 230.82 kB 231.44 kB +0.41% 56.02 kB 56.25 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.development.js +0.27% 231.62 kB 232.24 kB +0.41% 56.21 kB 56.44 kB
oss-stable/react-dom/cjs/react-dom-server.node.development.js +0.27% 231.62 kB 232.24 kB +0.41% 56.21 kB 56.44 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js +0.27% 231.77 kB 232.39 kB +0.41% 55.46 kB 55.69 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js +0.27% 231.88 kB 232.50 kB +0.40% 56.65 kB 56.87 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js +0.27% 232.24 kB 232.86 kB +0.41% 56.42 kB 56.65 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.development.js +0.27% 232.53 kB 233.14 kB +0.40% 56.49 kB 56.72 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.development.js +0.27% 232.53 kB 233.14 kB +0.40% 56.49 kB 56.72 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js +0.26% 233.04 kB 233.66 kB +0.39% 56.59 kB 56.81 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js +0.26% 233.95 kB 234.57 kB +0.41% 56.89 kB 57.13 kB
oss-stable-semver/react-dom/umd/react-dom-server.browser.development.js +0.26% 241.87 kB 242.51 kB +0.40% 56.87 kB 57.10 kB
oss-stable/react-dom/umd/react-dom-server.browser.development.js +0.26% 241.87 kB 242.51 kB +0.40% 56.87 kB 57.10 kB
oss-stable-semver/react-dom/umd/react-dom-server-legacy.browser.development.js +0.26% 242.27 kB 242.91 kB +0.40% 56.65 kB 56.88 kB
oss-stable/react-dom/umd/react-dom-server-legacy.browser.development.js +0.26% 242.27 kB 242.91 kB +0.40% 56.65 kB 56.88 kB
facebook-www/ReactDOMServer-dev.modern.js +0.26% 235.18 kB 235.80 kB +0.41% 56.25 kB 56.48 kB
oss-experimental/react-dom/umd/react-dom-server.browser.development.js +0.26% 243.37 kB 244.01 kB +0.39% 57.23 kB 57.45 kB
oss-experimental/react-dom/umd/react-dom-server-legacy.browser.development.js +0.26% 243.78 kB 244.41 kB +0.39% 57.02 kB 57.25 kB

Generated by 🚫 dangerJS against 3bca464

@gnoff gnoff merged commit 2bf5eba into facebook:main Apr 16, 2022
@gnoff gnoff deleted the fizz-escape-comment branch April 16, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants