Transfer head/body over if appending an HTML document #22876
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: c7917fe...eb9a4c6 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
gaearon
reviewed
Dec 7, 2021
| @@ -465,7 +465,49 @@ export function appendChild( | |||
| parentInstance: Instance, | |||
| child: Instance | TextInstance, | |||
| ): void { | |||
| parentInstance.appendChild(child); | |||
| const isDocumentParentNode = parentInstance.nodeType === DOCUMENT_NODE; | |||
There was a problem hiding this comment.
This is changing an extremely hot path and might break a bunch of optimisations. We need to be very careful about this.
sebmarkbage
requested changes
Dec 7, 2021
| @@ -465,7 +465,49 @@ export function appendChild( | |||
| parentInstance: Instance, | |||
| child: Instance | TextInstance, | |||
| ): void { | |||
| parentInstance.appendChild(child); | |||
There was a problem hiding this comment.
This is one of the hottest functions in React since it’s for every insertion for every node. It’s also typically inlined. It’s not the right trade off to put it here so we’ll need a different strategy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #22833 by making appending an HTML document instead copy over the attributes of HTML, Head, and Body (preserving the original HTML/Head/Body elements) and then setting the innerHTML of Body/Head.
This stops us from running into
Uncaught DOMException: Failed to execute 'appendChild' on 'Node': Only one element on document allowedwhile trying to client render a full page into document.How did you test this change?
Added a jest test
Confirmed issue #22833 is fixed: https://codesandbox.io/s/react-18-hydration-mismatch-in-document-forked-spxnt?file=/src/App.js