Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip dangerouslySetInnerHtml hydration warning if it's undefined #18676

Merged
merged 6 commits into from Apr 20, 2020
Merged

fix: skip dangerouslySetInnerHtml hydration warning if it's undefined #18676

merged 6 commits into from Apr 20, 2020

Commits on Apr 20, 2020

  1. test: Add failing case for dangerouslySetInnerHtml=undefined

    @eps1lon
    eps1lon committed Apr 20, 2020
    Copy the full SHA
    b14d38a View commit details
    Browse the repository at this point in the history

  2. fix: skip dangerouslySetInnerHtml warning if it's undefined

    @eps1lon
    eps1lon committed Apr 20, 2020
    Copy the full SHA
    47c0e9e View commit details
    Browse the repository at this point in the history

  3. test: add similar test that should trigger the warning

    @eps1lon
    eps1lon committed Apr 20, 2020
    Copy the full SHA
    b72da4e View commit details
    Browse the repository at this point in the history

  4. chore: Remove redundant nullish check

    @eps1lon
    eps1lon committed Apr 20, 2020
    Copy the full SHA
    5badbd9 View commit details
    Browse the repository at this point in the history

  5. Poke yarn_test_www_variant which timed out

    @eps1lon
    eps1lon committed Apr 20, 2020
    Copy the full SHA
    63387c2 View commit details
    Browse the repository at this point in the history

  6. test: Add smaller test for innerHTML=string to innerHTML=undefined

    @eps1lon
    eps1lon committed Apr 20, 2020
    Copy the full SHA
    5c05857 View commit details
    Browse the repository at this point in the history