Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bailout broken in lazy components due to default props resolving #18539

Merged
merged 3 commits into from Apr 8, 2020
Merged

Fix bailout broken in lazy components due to default props resolving #18539

merged 3 commits into from Apr 8, 2020

Commits on Apr 8, 2020

  1. Add failing tests for lazy components

    @jddxf
    jddxf committed Apr 8, 2020
    Copy the full SHA
    299ca45 View commit details
    Browse the repository at this point in the history

  2. Fix bailout broken in lazy components due to default props resolving 

    We should never compare unresolved props with resolved props. Since comparing
resolved props by reference doesn't make sense, we use unresolved props in that
case. Otherwise, resolved props are used.
    @jddxf
    jddxf committed Apr 8, 2020
    Copy the full SHA
    26c716f View commit details
    Browse the repository at this point in the history

  3. Avoid reassigning props warning when we bailout

    @jddxf
    jddxf committed Apr 8, 2020
    Copy the full SHA
    4e984ff View commit details
    Browse the repository at this point in the history