Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to latest release of babel #17897

Merged
merged 2 commits into from Jan 24, 2020
Merged

chore: update to latest release of babel #17897

merged 2 commits into from Jan 24, 2020

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Jan 23, 2020 •
edited

Summary

Fixes a couple of the test failures from #17896 and reduces the diff.

Updated babel by deleting everything @babel/* in the lockfile and running yarn

(Ironically my PR to Babel which broke the test: babel/babel#10361)

Test Plan

Green CI

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 23, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0c20528:

Sandbox Source
tender-poincare-h1937 Configuration

@SimenB SimenB mentioned this pull request Jan 23, 2020
Merged
@sizebot
Copy link

sizebot commented Jan 23, 2020 •
edited

Details of bundled changes.

Comparing: 3b3decf...0c20528

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% 0.0% 123.72 KB 123.72 KB 38.78 KB 38.78 KB NODE_PROFILING
react-dom-server.browser.development.js +0.6% +0.2% 137.99 KB 138.85 KB 36.67 KB 36.75 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 20.47 KB 20.47 KB 7.5 KB 7.5 KB UMD_PROD
react-dom-test-utils.development.js +0.1% +0.1% 54.76 KB 54.79 KB 15.39 KB 15.4 KB UMD_DEV
ReactDOMServer-prod.js -0.0% 0.0% 49.02 KB 49 KB 11.19 KB 11.19 KB FB_WWW_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 11.18 KB 11.18 KB 4.15 KB 4.15 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.21 KB 1.21 KB 710 B 711 B UMD_PROD
react-dom-test-utils.development.js +0.1% +0.1% 53.03 KB 53.06 KB 15.06 KB 15.08 KB NODE_DEV
ReactDOMUnstableNativeDependencies-dev.js -0.1% -0.1% 59.45 KB 59.41 KB 15.22 KB 15.2 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.05 KB 1.05 KB 641 B 642 B NODE_PROD
react-dom.development.js +0.1% 0.0% 957.32 KB 958.19 KB 215.12 KB 215.21 KB UMD_DEV
ReactDOMUnstableNativeDependencies-prod.js -0.2% -0.5% 25.19 KB 25.14 KB 5.03 KB 5.01 KB FB_WWW_PROD
react-dom.production.min.js 0.0% 0.0% 119.74 KB 119.74 KB 38.38 KB 38.39 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 123.47 KB 123.47 KB 39.56 KB 39.56 KB UMD_PROFILING
react-dom.development.js +0.1% 0.0% 951.39 KB 952.25 KB 213.41 KB 213.52 KB NODE_DEV
react-dom-server.node.development.js +0.6% +0.2% 135.03 KB 135.89 KB 35.88 KB 35.96 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 119.84 KB 119.84 KB 37.65 KB 37.65 KB NODE_PROD
ReactTestUtils-dev.js +0.1% +0.1% 52.25 KB 52.29 KB 14.25 KB 14.27 KB FB_WWW_DEV
react-dom-server.browser.development.js +0.6% +0.2% 133.92 KB 134.78 KB 35.65 KB 35.72 KB NODE_DEV
ReactDOM-dev.js +0.1% 0.0% 979 KB 979.82 KB 216.33 KB 216.39 KB FB_WWW_DEV
ReactDOM-prod.js -0.2% -0.2% 393.92 KB 393.13 KB 71.97 KB 71.81 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.91 KB 60.91 KB 16.07 KB 16.07 KB UMD_DEV
ReactDOM-profiling.js -0.2% -0.2% 405.22 KB 404.45 KB 74.12 KB 73.97 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10.23 KB 10.23 KB 3.47 KB 3.47 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.61 KB 60.61 KB 15.99 KB 16 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 4.42 KB 4.42 KB 1.65 KB 1.65 KB NODE_DEV
ReactDOMServer-dev.js +0.6% +0.2% 139.28 KB 140.18 KB 35.4 KB 35.46 KB FB_WWW_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.3% 1.21 KB 1.21 KB 696 B 698 B NODE_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 0c20528

@sizebot
Copy link

sizebot commented Jan 23, 2020 •
edited

Details of bundled changes.

Comparing: 3b3decf...0c20528

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-test-utils.development.js +0.1% +0.1% 53.02 KB 53.05 KB 15.06 KB 15.08 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 115.84 KB 115.84 KB 37.26 KB 37.26 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.59 KB 60.59 KB 15.99 KB 15.99 KB NODE_DEV
react-dom.profiling.min.js 0.0% 0.0% 119.46 KB 119.46 KB 38.41 KB 38.41 KB UMD_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 9.96 KB 9.96 KB 3.36 KB 3.36 KB NODE_PROD
react-dom.development.js +0.1% 0.0% 951.36 KB 952.23 KB 213.4 KB 213.5 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 115.91 KB 115.91 KB 36.61 KB 36.61 KB NODE_PROD
react-dom.profiling.min.js 0.0% 0.0% 119.68 KB 119.68 KB 37.72 KB 37.72 KB NODE_PROFILING
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.2 KB 1.2 KB 702 B 703 B UMD_PROD
react-dom-server.browser.development.js +0.6% +0.2% 137.96 KB 138.83 KB 36.67 KB 36.75 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.7 KB 3.7 KB 1.49 KB 1.5 KB NODE_DEV
react-dom-test-utils.development.js +0.1% +0.1% 54.74 KB 54.78 KB 15.38 KB 15.4 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.04 KB 1.04 KB 633 B 634 B NODE_PROD
react-dom-server.browser.development.js +0.6% +0.2% 133.9 KB 134.76 KB 35.65 KB 35.72 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 4.4 KB 4.4 KB 1.64 KB 1.64 KB NODE_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.1% 1.2 KB 1.2 KB 688 B 689 B NODE_PROD
react-dom-server.node.development.js +0.6% +0.2% 135.01 KB 135.87 KB 35.88 KB 35.95 KB NODE_DEV
react-dom.development.js +0.1% 0.0% 957.3 KB 958.17 KB 215.1 KB 215.19 KB UMD_DEV

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (stable)

Generated by 🚫 dangerJS against 0c20528

@SimenB SimenB changed the title Update babel chore: update to latest release of babel Jan 23, 2020
@necolas
Copy link
Contributor

necolas commented Jan 23, 2020

Thanks. We should probably bump the base versions of the dependencies in the package.json too https://github.com/facebook/react/blob/master/package.json#L7

@SimenB
Copy link
Contributor Author

SimenB commented Jan 24, 2020

@necolas any particular reason to? They're all in devDependencies so not user facing at all, meaning the version in the lockfile should be all that matters.

@trueadm
Copy link
Contributor

trueadm commented Jan 24, 2020

@SimenB We should update the package.json devDependencies anyway, but also it makes sense for users who might not be using Yarn?

@SimenB
Copy link
Contributor Author

SimenB commented Jan 24, 2020

@necolas @trueadm updated

@trueadm
Copy link
Contributor

trueadm commented Jan 24, 2020

Looks good, thank you!

@trueadm trueadm merged commit 3c713d5 into facebook:master Jan 24, 2020
@SimenB SimenB deleted the update-babel branch January 24, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MayasHaddad MayasHaddad MayasHaddad approved these changes

@nvana nvana nvana approved these changes

@jameskip jameskip jameskip approved these changes

@eduardo-yieldstreet eduardo-yieldstreet eduardo-yieldstreet approved these changes

@kylemcd kylemcd kylemcd approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@SimenB @sizebot @necolas @trueadm @MayasHaddad @nvana @jameskip @eduardo-yieldstreet @kylemcd @facebook-github-bot