Remove renderPhaseUpdates Map #17625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 811a659:
|
Details of bundled changes.Comparing: 29b4d07...811a659 react-dom
react-test-renderer
react-native-renderer
react-art
react-reconciler
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (experimental) |
Details of bundled changes.Comparing: 29b4d07...811a659 react-art
react-reconciler
react-native-renderer
react-dom
react-test-renderer
ReactDOM: size: 🔺+0.4%, gzip: 🔺+0.2% Size changes (stable) |
acdlite
force-pushed
the
remove-render-phase-map
branch
from
a35a6c6
to
a37b65e
Compare
acdlite
commented
Dec 16, 2019
| // | ||
| // Only reset the updates from the queue if it has a clone. If it does | ||
| // not have a clone, that means it wasn't processed, and the updates were | ||
| // scheduled before we entered the render phase. |
There was a problem hiding this comment.
@sebmarkbage I think if we change the list to an array, we would just need some other mechanism to determine if it was processed or not. I added tests so we don't forget.
acdlite
force-pushed
the
remove-render-phase-map
branch
from
9c445d4
to
85b2209
Compare
|
Ok I think this is ready for review now |
acdlite
force-pushed
the
remove-render-phase-map
branch
4 times, most recently
from
6f4d988
to
3045820
Compare
acdlite
force-pushed
the
remove-render-phase-map
branch
3 times, most recently
from
33d7247
to
37d0878
Compare
Follow up to facebook#17484, which was reverted due to a bug found in www.
When resetting render phase updates after a throw, we should only clear the pending queue of hooks that were already processed.
Detects if a queue has been processed by whether the hook was cloned. If we change the implementation to an array instead of a list, we'll need some other mechanism to determine whether the hook was processed.
useTransition uses the state hook as part of its implementation, so we need to fork it in the dispatcher used for re-renders, too.
acdlite
force-pushed
the
remove-render-phase-map
branch
from
37d0878
to
811a659
Compare
sebmarkbage
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #17484, which was reverted due to a bug found in www.
(I haven't actually found this bug yet, still trying to repro.)Found and fixedAlso addresses a separate bug where updates that are thought to be render phase updates are cleared, but they are actually normal updates: 8a347ed#r36440099