Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove renderPhaseUpdates Map" #17623

Merged
merged 1 commit into from Dec 16, 2019
Merged

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Dec 16, 2019

Reverts #17484

Seems like there's a bug (https://fburl.com/testinfra/hvcgkcp0). Let's revert to unblock the sync.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6807fde:

Sandbox Source
cool-mclean-idqz8 Configuration

@sizebot
Copy link

sizebot commented Dec 16, 2019

Details of bundled changes.

Comparing: 0b5a26a...6807fde

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-prod.js -0.1% -0.2% 267.53 KB 267.28 KB 46.19 KB 46.09 KB RN_FB_PROD
ReactNativeRenderer-dev.js -0.9% -0.1% 745.72 KB 739.29 KB 157.17 KB 157.01 KB RN_OSS_DEV
ReactFabric-profiling.js -0.1% -0.2% 277.63 KB 277.39 KB 48.06 KB 47.94 KB RN_FB_PROFILING
ReactNativeRenderer-prod.js -0.1% -0.2% 275.87 KB 275.63 KB 47.55 KB 47.45 KB RN_FB_PROD
ReactNativeRenderer-profiling.js -0.1% -0.2% 284.8 KB 284.56 KB 49.27 KB 49.18 KB RN_FB_PROFILING
ReactFabric-dev.js -0.9% -0.1% 750.73 KB 744.3 KB 157.93 KB 157.78 KB RN_OSS_DEV
ReactFabric-prod.js -0.1% -0.2% 267.18 KB 266.93 KB 46.12 KB 46.02 KB RN_OSS_PROD
ReactFabric-profiling.js -0.1% -0.3% 277.29 KB 277.04 KB 48 KB 47.87 KB RN_OSS_PROFILING
ReactFabric-dev.js -0.9% -0.1% 750.91 KB 744.48 KB 158.02 KB 157.87 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.1% -0.2% 275.48 KB 275.24 KB 47.48 KB 47.38 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.1% -0.2% 284.41 KB 284.17 KB 49.21 KB 49.11 KB RN_OSS_PROFILING
ReactNativeRenderer-dev.js -0.9% -0.1% 745.89 KB 739.47 KB 157.25 KB 157.1 KB RN_FB_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -1.0% -0.1% 618.03 KB 611.56 KB 130.86 KB 130.71 KB UMD_DEV
react-test-renderer.production.min.js -0.3% -0.3% 71.46 KB 71.22 KB 21.98 KB 21.91 KB UMD_PROD
ReactTestRenderer-dev.js -1.0% -0.1% 627.81 KB 621.35 KB 130.19 KB 130.04 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 37.58 KB 37.58 KB 9.73 KB 9.72 KB UMD_DEV
react-test-renderer.development.js -1.1% -0.1% 613.3 KB 606.83 KB 129.69 KB 129.54 KB NODE_DEV
react-test-renderer.production.min.js -0.3% -0.1% 71.17 KB 70.93 KB 21.57 KB 21.55 KB NODE_PROD

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js -0.2% 0.0% 123.32 KB 123.07 KB 38.8 KB 38.8 KB NODE_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.88 KB 3.88 KB 1.55 KB 1.55 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.21 KB 1.21 KB 711 B 709 B UMD_PROD
ReactDOMServer-dev.js 0.0% -0.0% 138.03 KB 138.03 KB 35.11 KB 35.11 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 52.65 KB 52.65 KB 14.94 KB 14.94 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.71 KB 3.71 KB 1.5 KB 1.5 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.95 KB 10.95 KB 4.09 KB 4.09 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.05 KB 1.05 KB 642 B 641 B NODE_PROD
react-dom.development.js -0.7% -0.1% 953.23 KB 946.76 KB 214.9 KB 214.75 KB UMD_DEV
react-dom.production.min.js -0.2% -0.0% 119.36 KB 119.12 KB 38.44 KB 38.43 KB UMD_PROD
react-dom.profiling.min.js -0.2% -0.4% 123.05 KB 122.81 KB 39.65 KB 39.49 KB UMD_PROFILING
react-dom.development.js -0.7% -0.1% 947.29 KB 940.83 KB 213.25 KB 213.1 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 134.44 KB 134.44 KB 35.73 KB 35.73 KB NODE_DEV
react-dom.production.min.js -0.2% 🔺+0.1% 119.51 KB 119.27 KB 37.78 KB 37.81 KB NODE_PROD
react-dom-server.browser.development.js 0.0% 0.0% 133.33 KB 133.33 KB 35.5 KB 35.5 KB NODE_DEV
ReactDOM-dev.js -0.7% -0.1% 973.92 KB 967.47 KB 215.8 KB 215.65 KB FB_WWW_DEV
ReactDOM-prod.js -0.0% -0.1% 402.86 KB 402.69 KB 73.63 KB 73.52 KB FB_WWW_PROD
ReactDOM-profiling.js -0.0% -0.1% 403.79 KB 403.61 KB 74.19 KB 74.09 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 9.97 KB 9.97 KB 3.37 KB 3.37 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.3% 1.21 KB 1.21 KB 698 B 696 B NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js -1.0% -0.1% 616.4 KB 609.95 KB 127.61 KB 127.47 KB FB_WWW_DEV
ReactART-prod.js -0.1% -0.2% 235.71 KB 235.53 KB 40.08 KB 39.99 KB FB_WWW_PROD
react-art.development.js -1.0% -0.1% 673.19 KB 666.73 KB 145.23 KB 145.1 KB UMD_DEV
react-art.production.min.js -0.2% -0.4% 106.43 KB 106.19 KB 32.48 KB 32.35 KB UMD_PROD
react-art.development.js -1.1% -0.1% 603.83 KB 597.37 KB 127.83 KB 127.69 KB NODE_DEV
react-art.production.min.js -0.3% 🔺+0.1% 71.4 KB 71.16 KB 21.47 KB 21.5 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler-persistent.development.js -1.1% -0.1% 602.29 KB 595.82 KB 125.87 KB 125.73 KB NODE_DEV
react-reconciler-reflection.development.js 0.0% -0.0% 19 KB 19 KB 6.25 KB 6.25 KB NODE_DEV
react-reconciler-persistent.production.min.js -0.3% -0.0% 72.22 KB 71.97 KB 21.31 KB 21.31 KB NODE_PROD
react-reconciler.development.js -1.1% -0.1% 604.81 KB 598.35 KB 126.98 KB 126.83 KB NODE_DEV
react-reconciler.production.min.js -0.3% -0.1% 74.43 KB 74.18 KB 21.89 KB 21.87 KB NODE_PROD

Size changes (experimental)

Generated by 🚫 dangerJS against 6807fde

@sizebot
Copy link

sizebot commented Dec 16, 2019

Details of bundled changes.

Comparing: 0b5a26a...6807fde

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.production.min.js -0.3% -0.0% 72.19 KB 71.94 KB 21.3 KB 21.29 KB NODE_PROD
react-reconciler-persistent.development.js -1.1% -0.1% 602.27 KB 595.81 KB 125.86 KB 125.73 KB NODE_DEV
react-reconciler-persistent.production.min.js -0.3% -0.0% 72.2 KB 71.95 KB 21.31 KB 21.3 KB NODE_PROD
react-reconciler.development.js -1.1% -0.1% 604.8 KB 598.34 KB 126.98 KB 126.83 KB NODE_DEV
react-reconciler-reflection.development.js 0.0% -0.0% 18.99 KB 18.99 KB 6.25 KB 6.25 KB NODE_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-server.browser.development.js 0.0% 0.0% 133.31 KB 133.31 KB 35.5 KB 35.5 KB NODE_DEV
react-dom.development.js -0.7% -0.1% 953.21 KB 946.74 KB 214.87 KB 214.73 KB UMD_DEV
react-dom.production.min.js -0.2% -0.2% 116.01 KB 115.77 KB 37.52 KB 37.46 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.2 KB 1.2 KB 703 B 701 B UMD_PROD
react-dom.profiling.min.js -0.2% -0.3% 119.58 KB 119.35 KB 38.64 KB 38.54 KB UMD_PROFILING
react-dom.development.js -0.7% -0.1% 947.27 KB 940.81 KB 213.22 KB 213.07 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.7 KB 3.7 KB 1.49 KB 1.49 KB NODE_DEV
react-dom.production.min.js -0.2% 0.0% 116.13 KB 115.88 KB 36.85 KB 36.87 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.04 KB 1.04 KB 634 B 633 B NODE_PROD
react-dom.profiling.min.js -0.2% -0.1% 119.82 KB 119.58 KB 37.84 KB 37.82 KB NODE_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.22 KB 10.22 KB 3.47 KB 3.47 KB UMD_PROD
react-dom-server.node.development.js 0.0% 0.0% 134.42 KB 134.42 KB 35.73 KB 35.73 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 11.17 KB 11.17 KB 4.14 KB 4.14 KB UMD_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.3% 1.2 KB 1.2 KB 690 B 688 B NODE_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 19.93 KB 19.93 KB 7.39 KB 7.38 KB UMD_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -1.0% -0.1% 673.17 KB 666.7 KB 145.23 KB 145.09 KB UMD_DEV
react-art.production.min.js -0.2% -0.2% 104.41 KB 104.17 KB 31.89 KB 31.83 KB UMD_PROD
react-art.development.js -1.1% -0.1% 603.81 KB 597.35 KB 127.82 KB 127.68 KB NODE_DEV
react-art.production.min.js -0.3% -0.1% 69.42 KB 69.18 KB 21 KB 20.98 KB NODE_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -1.0% -0.1% 618 KB 611.54 KB 130.85 KB 130.7 KB UMD_DEV
react-test-renderer.production.min.js -0.3% -0.3% 71.44 KB 71.19 KB 21.96 KB 21.9 KB UMD_PROD
react-test-renderer.development.js -1.1% -0.1% 613.27 KB 606.8 KB 129.67 KB 129.52 KB NODE_DEV
react-test-renderer.production.min.js -0.3% -0.1% 71.14 KB 70.9 KB 21.55 KB 21.53 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.9% -0.1% 745.88 KB 739.45 KB 157.25 KB 157.09 KB RN_FB_DEV
ReactNativeRenderer-prod.js -0.1% -0.2% 275.86 KB 275.61 KB 47.54 KB 47.44 KB RN_FB_PROD
ReactNativeRenderer-profiling.js -0.1% -0.2% 284.79 KB 284.54 KB 49.26 KB 49.17 KB RN_FB_PROFILING
ReactFabric-dev.js -0.9% -0.1% 750.9 KB 744.47 KB 158.01 KB 157.86 KB RN_FB_DEV
ReactFabric-prod.js -0.1% -0.2% 267.51 KB 267.27 KB 46.18 KB 46.08 KB RN_FB_PROD
ReactFabric-profiling.js -0.1% -0.2% 277.62 KB 277.38 KB 48.05 KB 47.93 KB RN_FB_PROFILING
ReactNativeRenderer-dev.js -0.9% -0.1% 745.71 KB 739.28 KB 157.16 KB 157 KB RN_OSS_DEV
ReactNativeRenderer-prod.js -0.1% -0.2% 275.47 KB 275.22 KB 47.47 KB 47.37 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js -0.1% -0.2% 284.4 KB 284.16 KB 49.2 KB 49.11 KB RN_OSS_PROFILING
ReactFabric-dev.js -0.9% -0.1% 750.71 KB 744.28 KB 157.93 KB 157.77 KB RN_OSS_DEV
ReactFabric-prod.js -0.1% -0.2% 267.17 KB 266.92 KB 46.11 KB 46.01 KB RN_OSS_PROD
ReactFabric-profiling.js -0.1% -0.3% 277.27 KB 277.03 KB 47.99 KB 47.87 KB RN_OSS_PROFILING

ReactDOM: size: -0.2%, gzip: -0.2%

Size changes (stable)

Generated by 🚫 dangerJS against 6807fde

@gaearon gaearon merged commit f42431a into master Dec 16, 2019
@kassens kassens deleted the revert-17484-hook-rerender branch November 29, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants