Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fewer global variables in Hooks #17480

Merged
merged 9 commits into from Dec 3, 2019
Merged

Use fewer global variables in Hooks #17480

merged 9 commits into from Dec 3, 2019

Commits on Nov 28, 2019

  1. We don't need the global state for this

    @sebmarkbage
    sebmarkbage committed Nov 28, 2019
    Copy the full SHA
    afc8eee View commit details
    Browse the repository at this point in the history

  2. Move componentUpdateQueue and sideEffectTag out of global state

    @sebmarkbage
    sebmarkbage committed Nov 28, 2019
    Copy the full SHA
    302610c View commit details
    Browse the repository at this point in the history

  3. Move remainingExpirationTime off global state

    @sebmarkbage
    sebmarkbage committed Nov 28, 2019
    Copy the full SHA
    0d0bc76 View commit details
    Browse the repository at this point in the history

  4. Move firstWorkInProgressHook off global state

    @sebmarkbage
    sebmarkbage committed Nov 28, 2019
    Copy the full SHA
    d4b1793 View commit details
    Browse the repository at this point in the history

  5. Reset fiber to its current state if it throws

    @sebmarkbage
    sebmarkbage committed Nov 28, 2019
    Copy the full SHA
    0432096 View commit details
    Browse the repository at this point in the history

  6. Move rerender error check to avoid global state 

    This means that it's harder to find it since it's not in the dispatch
function's stack but we can add a DEV only one for that if we really
need it. Alternatively, we can check it in against the renderUpdates queue.
    @sebmarkbage
    sebmarkbage committed Nov 28, 2019
    Copy the full SHA
    3e77742 View commit details
    Browse the repository at this point in the history

  7. Move next___Hook out of global state

    @sebmarkbage
    sebmarkbage committed Nov 28, 2019
    Copy the full SHA
    cc1aa9d View commit details
    Browse the repository at this point in the history

  8. Assert that currentlyRenderingFiber is always set 

    When accessed, this should always be set. This could enforced by storing
this on the dispatcher for example.
    @sebmarkbage
    sebmarkbage committed Nov 28, 2019
    Copy the full SHA
    25aa2e5 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. Add another test just to be safe

    @sebmarkbage
    sebmarkbage committed Dec 3, 2019
    Copy the full SHA
    1ea22f8 View commit details
    Browse the repository at this point in the history