Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Warning for Uncontrolled/Controlled Inputs Clearer #17390

Conversation

codingnspace
Copy link

Fixes #17069. To make the warnings for switching between uncontrolled and controlled inputs clearer. Uses language that was suggested by @markerikson in #17069

@facebook-github-bot
Copy link

Hi codingnspace! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@sizebot
Copy link

sizebot commented Nov 17, 2019

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 011b9e7

@sizebot
Copy link

sizebot commented Nov 17, 2019

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 011b9e7

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 17, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 011b9e7:

Sandbox Source
modest-jackson-jmo8z Configuration

@stale
Copy link

stale bot commented Feb 16, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Feb 16, 2020
@stale
Copy link

stale bot commented Feb 23, 2020

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@stale stale bot closed this Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The warning for uncontrolled -> controlled inputs is confusing
5 participants