Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for 16.12 #17370

Closed
wants to merge 2 commits into from
Closed

Changelog for 16.12 #17370

wants to merge 2 commits into from

Conversation

lunaruan
Copy link
Contributor

16.12.0 (November 14, 2019)

React DOM

  • Fix passive effects (useEffect) not being fired in a multi-root app. @acdlite in #17347

React IS

  • Fix lazy and memo types considered elements instead of components @bvaughn in #17278

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fa8739c:

Sandbox Source
naughty-hodgkin-zhs14 Configuration

@sizebot
Copy link

sizebot commented Nov 14, 2019

Warnings
⚠️ Base commit is broken: 769dd52

Size changes (stable)

Generated by 🚫 dangerJS against fa8739c

@sizebot
Copy link

sizebot commented Nov 14, 2019

Warnings
⚠️ Base commit is broken: 769dd52

Size changes (experimental)

Generated by 🚫 dangerJS against fa8739c


* Fix passive effects (`useEffect`) not being fired in a multi-root app. [@acdlite](https://github.com/acdlite) in [#17347](https://github.com/facebook/react/pull/17347)

### React IS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(It's not an abbreviation)


### React DOM

* Fix passive effects (`useEffect`) not being fired in a multi-root app. [@acdlite](https://github.com/acdlite) in [#17347](https://github.com/facebook/react/pull/17347)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we usually put parens around "@xxx in #yyy"

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

@lunaruan lunaruan closed this Nov 15, 2019
@lunaruan lunaruan deleted the changelog branch November 15, 2019 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants