[react-core] Do not null fiber.sibling in detachFiber #16820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threepointone
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered an issue internally when using
findDOMNodeand the changes introduced in #16807. Specifically, setting the fibersiblingfield tonullis problematic in that it runs into this invariant:https://github.com/facebook/react/blob/master/packages/react-reconciler/src/ReactFiberTreeReflection.js#L213-L214
We traverse through the children of the fiber by going from fiber to fiber using
sibling. Doing this, we encounter a child fiber that has been detatched earlier and thus has no sibling anymore, but the code forfindCurrentFiberUsingSlowPathexpects it should.We need to revisit this, but for now, let's revert this specific change. I'll also try and make a repro when I get a chance and put in a follow up.