[Partial Hydration] Dehydrated suspense boundaries in SuspenseList #16369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
sebmarkbage
force-pushed
the
dehydratedsuspenselist
branch
from
c2696d4
to
a534bdf
Compare
acdlite
approved these changes
Aug 12, 2019
If we get an insertion after a boundary, that has not yet been hydrated, we take our best guess at which state the HTML is showing. isSuspenseInstancePending means that we're still waiting for more server HTML before we can hydrate. This should mean that we're showing the fallback state. isSuspenseInstanceFallback means that we want to client render something. That most likely means that the server was unable to render and is displaying a fallback state in this slot. Adds tests to ensure that dehydrated components don't consider the force flag.
sebmarkbage
force-pushed
the
dehydratedsuspenselist
branch
from
a534bdf
to
bde4066
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #16352 and #16359
If we get an insertion after a boundary, that has not yet been hydrated, we take our best guess at which state the HTML is showing.
isSuspenseInstancePending means that we're still waiting for more server HTML before we can hydrate. This should mean that we're showing the fallback state.
isSuspenseInstanceFallback means that we want to client render something. That most likely means that the server was unable to render and is displaying a fallback state in this slot.
Adds tests to ensure that dehydrated components don't consider the force flag set by suspense list. I.e. we should be able to hydrate something that is already showing content even though insertions are forced into fallback state.