Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scheduler] Store Tasks on a Min Binary Heap #16245

Merged
merged 2 commits into from Aug 8, 2019
Merged

[Scheduler] Store Tasks on a Min Binary Heap #16245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
220ba25
[Scheduler] Store Tasks on a Min Binary Heap
acdlite Jul 29, 2019
f2318c1
Sophie nits
acdlite Aug 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 3 additions & 15 deletions packages/react-dom/src/__tests__/ReactUpdates-test.js
View file
Open in desktop
Expand Up @@ -1631,6 +1631,7 @@ describe('ReactUpdates', () => {
ReactDOM.render(<App />, container);
while (error === null) {
Scheduler.unstable_flushNumberOfYields(1);
Scheduler.unstable_clearYields();
}
expect(error).toContain('Warning: Maximum update depth exceeded.');
expect(stack).toContain('in NonTerminating');
Expand All @@ -1653,34 +1654,21 @@ describe('ReactUpdates', () => {
React.useEffect(() => {
if (step < LIMIT) {
setStep(x => x + 1);
Scheduler.unstable_yieldValue(step);
}
});
Scheduler.unstable_yieldValue(step);
return step;
}

const container = document.createElement('div');
act(() => {
ReactDOM.render(<Terminating />, container);
});

// Verify we can flush them asynchronously without warning
for (let i = 0; i < LIMIT * 2; i++) {
Scheduler.unstable_flushNumberOfYields(1);
}
expect(container.textContent).toBe('50');

// Verify restarting from 0 doesn't cross the limit
act(() => {
_setStep(0);
// flush once to update the dom
Scheduler.unstable_flushNumberOfYields(1);
expect(container.textContent).toBe('0');
for (let i = 0; i < LIMIT * 2; i++) {
Scheduler.unstable_flushNumberOfYields(1);
}
expect(container.textContent).toBe('50');
});
expect(container.textContent).toBe('50');
});

it('can have many updates inside useEffect without triggering a warning', () => {
Expand Down