Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch release branch for 16.8.3 #14902

Closed
wants to merge 3 commits into from
Closed

Patch release branch for 16.8.3 #14902

wants to merge 3 commits into from

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Feb 20, 2019 •
edited by gaearon

Includes two bugfixes cherry-picked onto the commit of the 16.8.2 release (3e55560).

Canary release: 0.0.0-b668168d4

Changelog

React DOM

  • Fix a bug that caused inputs to behave incorrectly in UMD builds. (@gaearon in #14914)
  • Fix a bug that caused render phase updates to be discarded. (@gaearon in #14852)

React DOM Server

  • Unwind the context stack when a stream is destroyed without completing, to prevent incorrect values during a subsequent render. (@overlookmotel in #14706)

Test plan

gaearon and others added 2 commits February 20, 2019 11:24
@gaearon @acdlite
Don't discard render phase state updates with the eager reducer optim…
619cdfc 
…ization (facebook#14852)

* Add test cases for setState(fn) + render phase updates

* Update eager state and reducer for render phase updates

* Fix a newly firing warning
@overlookmotel @acdlite
Fix react-dom/server context leaks when render stream destroyed early (…
b668168 
…facebook#14706)

* Fix react-dom/server context memory retention

* Test for pollution of later renders

* Inline loop

* More tests
@sizebot
Copy link

sizebot commented Feb 20, 2019 •
edited

ReactDOM: size: 0.0%, gzip: 0.0%

Details of bundled changes.

Comparing: 3e55560...29b7b77

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 765.35 KB 765.42 KB 174.45 KB 174.46 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 105.34 KB 105.37 KB 33.94 KB 33.94 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 108.26 KB 108.29 KB 34.82 KB 34.82 KB UMD_PROFILING
react-dom.development.js 0.0% 0.0% 759.95 KB 760.03 KB 172.96 KB 172.97 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 105.5 KB 105.53 KB 33.43 KB 33.43 KB NODE_PROD
react-dom.profiling.min.js 0.0% 0.0% 108.58 KB 108.61 KB 34.25 KB 34.25 KB NODE_PROFILING
ReactDOM-dev.js 0.0% 0.0% 782.94 KB 783.01 KB 174.19 KB 174.2 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 321.54 KB 321.61 KB 58.61 KB 58.62 KB FB_WWW_PROD
ReactDOM-profiling.js 0.0% 0.0% 328.11 KB 328.18 KB 60.1 KB 60.1 KB FB_WWW_PROFILING
react-dom-unstable-fire.development.js 0.0% 0.0% 765.7 KB 765.77 KB 174.59 KB 174.6 KB UMD_DEV
react-dom-unstable-fire.production.min.js 0.0% 0.0% 105.35 KB 105.39 KB 33.95 KB 33.95 KB UMD_PROD
react-dom-unstable-fire.profiling.min.js 0.0% -0.0% 108.27 KB 108.3 KB 34.83 KB 34.82 KB UMD_PROFILING
react-dom-unstable-fire.development.js 0.0% 0.0% 760.3 KB 760.37 KB 173.1 KB 173.11 KB NODE_DEV
react-dom-unstable-fire.production.min.js 0.0% 0.0% 105.52 KB 105.55 KB 33.44 KB 33.44 KB NODE_PROD
react-dom-unstable-fire.profiling.min.js 0.0% 0.0% 108.59 KB 108.62 KB 34.26 KB 34.26 KB NODE_PROFILING
ReactFire-dev.js 0.0% 0.0% 782.15 KB 782.22 KB 174.11 KB 174.12 KB FB_WWW_DEV
ReactFire-prod.js 0.0% 0.0% 309.96 KB 310.04 KB 56.29 KB 56.29 KB FB_WWW_PROD
ReactFire-profiling.js 0.0% 0.0% 316.58 KB 316.65 KB 57.7 KB 57.71 KB FB_WWW_PROFILING
react-dom-test-utils.development.js 0.0% -0.0% 47.06 KB 47.06 KB 12.99 KB 12.99 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.27 KB 10.27 KB 3.8 KB 3.8 KB UMD_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 10.05 KB 10.05 KB 3.73 KB 3.73 KB NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 11.01 KB 11.01 KB 3.81 KB 3.81 KB UMD_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.75 KB 10.75 KB 3.71 KB 3.71 KB NODE_PROD
react-dom-server.browser.development.js +0.3% +0.2% 126.78 KB 127.18 KB 33.81 KB 33.88 KB UMD_DEV
react-dom-server.browser.production.min.js 🔺+0.8% 🔺+0.4% 18.69 KB 18.85 KB 7.19 KB 7.22 KB UMD_PROD
react-dom-server.browser.development.js +0.3% +0.2% 122.91 KB 123.31 KB 32.87 KB 32.94 KB NODE_DEV
react-dom-server.browser.production.min.js 🔺+0.8% 🔺+0.5% 18.62 KB 18.77 KB 7.17 KB 7.2 KB NODE_PROD
ReactDOMServer-dev.js +0.3% +0.2% 123.85 KB 124.25 KB 32.38 KB 32.45 KB FB_WWW_DEV
ReactDOMServer-prod.js 🔺+0.5% 🔺+0.4% 44.98 KB 45.22 KB 10.37 KB 10.42 KB FB_WWW_PROD
react-dom-server.node.development.js +0.3% +0.2% 124.97 KB 125.37 KB 33.41 KB 33.48 KB NODE_DEV
react-dom-server.node.production.min.js 🔺+0.8% 🔺+0.5% 19.49 KB 19.65 KB 7.48 KB 7.51 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.63 KB 3.63 KB 1.44 KB 1.44 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.21 KB 1.21 KB 705 B 707 B UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.05 KB 1.05 KB 637 B 638 B NODE_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 3.7 KB 3.7 KB 1.42 KB 1.42 KB NODE_DEV

Generated by 🚫 dangerJS

This was referenced Feb 21, 2019
Closed
Closed
gaearon
gaearon requested changes Feb 21, 2019
View reviewed changes
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get #14914 in too.

@gaearon gaearon closed this Feb 23, 2019
@fregante fregante mentioned this pull request Apr 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon requested changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@acdlite @sizebot @gaearon @facebook-github-bot @overlookmotel