Simplify CSS shorthand property warning #14183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I figured out a simpler way to do facebook#14181. It does allocate some but I think that's OK. Time complexity might even be better since we avoid the nested loops the old one had.
|
Are we ok releasing the first one in a patch release? I think we should probably add this warning behind a feature flag since it is likely to be very noisy. |
Details of bundled changes.Comparing: 961eb65...c92e400 react-dom
Generated by 🚫 dangerJS |
|
I don't think this will be very noisy. I think it basically always indicates a real bug. |
|
In that case we should first turn it on internally and verify that assumption. |
|
Happy to. If we want to cut a patch first we can disable it temporarily I guess. |
sebmarkbage
approved these changes
Nov 10, 2018
Merged
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
I figured out a simpler way to do facebook#14181. It does allocate some but I think that's OK. Time complexity might even be better since we avoid the nested loops the old one had.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
I figured out a simpler way to do facebook#14181. It does allocate some but I think that's OK. Time complexity might even be better since we avoid the nested loops the old one had.
|
@astr0sl0th This PR has been merged a year ago. Please don’t leave reviews on old PRs, you’re spamming everyone’s notifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured out a simpler way to do #14181. It does allocate some but I think that's OK. Time complexity might even be better since we avoid the nested loops the old one had.