Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about conflicting style values during updates #14181

Merged
merged 1 commit into from Nov 9, 2018
Merged

Warn about conflicting style values during updates #14181

merged 1 commit into from Nov 9, 2018

Commits on Nov 9, 2018

  1. Warn about conflicting style values during updates 

    This is one of the most insidious quirks of React DOM that people run into. Now we warn when we think an update is dangerous.

We still allow rendering `{background, backgroundSize}` with unchanging values, for example. But once you remove either one or change `background` (without changing `backgroundSize` at the same time), that's bad news. So we warn.

Fixes facebook#6348.
    @sophiebits
    sophiebits committed Nov 9, 2018
    Copy the full SHA
    399ac96 View commit details
    Browse the repository at this point in the history