Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about css shorthand properties collision(#6348) #13860

Closed

Conversation

logic0319
Copy link

@logic0319 logic0319 commented Oct 16, 2018

I only added background shorthand properties.
After code review, I would like to add rest of them.

Fixes #6348.

@sizebot
Copy link

sizebot commented Oct 16, 2018

ReactDOM: size: 0.0%, gzip: 0.0%

Details of bundled changes.

Comparing: 0af8199...4fe3708

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.1% +0.2% 656.95 KB 657.85 KB 153.51 KB 153.76 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 95.64 KB 95.64 KB 31.15 KB 31.16 KB UMD_PROD
react-dom.development.js +0.1% +0.2% 652.29 KB 653.2 KB 152.13 KB 152.38 KB NODE_DEV
react-dom.production.min.js -0.0% 0.0% 95.63 KB 95.63 KB 30.74 KB 30.74 KB NODE_PROD
react-dom-server.browser.development.js 0.0% 0.0% 106.06 KB 106.06 KB 28.2 KB 28.2 KB UMD_DEV
react-dom-server.browser.development.js 0.0% 0.0% 102.19 KB 102.19 KB 27.2 KB 27.2 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 104.11 KB 104.11 KB 27.76 KB 27.76 KB NODE_DEV
ReactDOM-dev.js +0.2% +0.2% 669.21 KB 670.25 KB 152.73 KB 153.01 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% -0.0% 286.99 KB 286.99 KB 52.78 KB 52.78 KB FB_WWW_PROD
react-dom.profiling.min.js -0.0% -0.0% 98.42 KB 98.42 KB 31.3 KB 31.29 KB NODE_PROFILING
ReactDOM-profiling.js 0.0% -0.0% 293.18 KB 293.18 KB 54.13 KB 54.13 KB FB_WWW_PROFILING
react-dom.profiling.min.js 0.0% 0.0% 98.35 KB 98.35 KB 31.78 KB 31.79 KB UMD_PROFILING

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@sophiebits
Copy link
Collaborator

Thanks for sending this @YongPilMoon! I realized as I was reviewing that solving this correctly is a bit tricker than I had anticipated so I opted to finish it off myself in #14181. Feel free to comment on my PR if you notice any issues with it, and thanks for taking a first stab at this.

@sophiebits sophiebits closed this Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants