Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t add onclick listener to React root #13778

Merged
merged 6 commits into from
Oct 9, 2018
Merged

Don’t add onclick listener to React root #13778

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
45578e6
Don’t add onclick listener to React root
philipp-spiess Oct 4, 2018
f78da30
Make Flow happy by giving it more context
philipp-spiess Oct 4, 2018
965b17c
It’s time to go to bed
philipp-spiess Oct 5, 2018
f0c2702
Check for null and undefined explicitly
philipp-spiess Oct 5, 2018
4cf7175
We don't use destructuring
philipp-spiess Oct 5, 2018
ea25fe7
Cleanup DOMContainer usage and test assertions
philipp-spiess Oct 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/react-dom/src/client/ReactDOMHostConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,9 +366,14 @@ export function appendChildToContainer(
// through the React tree. However, on Mobile Safari the click would
// never bubble through the *DOM* tree unless an ancestor with onclick
// event exists. So we wouldn't see it and dispatch it.
// This is why we ensure that containers have inline onclick defined.
// This is why we ensure that non React root containers have inline onclick
// defined.
// https://github.com/facebook/react/issues/11918
if (!container._reactRootContainer && parentNode.onclick === null) {
const {_reactRootContainer} = container;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another style nit: we don't use destructuring, with some exceptions like module-style objects or function args (component props).

if (
(_reactRootContainer === null || _reactRootContainer === undefined) &&
parentNode.onclick === null
) {
// TODO: This cast may not be sound for SVG, MathML or custom elements.
trapClickOnNonInteractiveElement(((parentNode: any): HTMLElement));
}
Expand Down