Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable getDerivedStateFromError #13746

Merged
merged 10 commits into from
Sep 28, 2018
Merged

Enable getDerivedStateFromError #13746

merged 10 commits into from
Sep 28, 2018

Commits on Sep 27, 2018

  1. Removed the enableGetDerivedStateFromCatch feature flag (aka permanen… 

    …tly enabled the feature)
    Brian Vaughn committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    4ed84b0 View commit details
    Browse the repository at this point in the history

  2. Forked/copied ReactErrorBoundaries to ReactLegacyErrorBoundaries for … 

    …testing componentDidCatch
    Brian Vaughn committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    cd49672 View commit details
    Browse the repository at this point in the history

  3. Updated error boundaries tests to apply to getDerivedStateFromCatch a… 

    …nd fixed a minor reconciliation error in begin work.
    Brian Vaughn committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    56bbf1c View commit details
    Browse the repository at this point in the history

  4. Renamed getDerivedStateFromCatch -> getDerivedStateFromError

    Brian Vaughn committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    f6fb111 View commit details
    Browse the repository at this point in the history

  5. Warn if boundary with only componentDidCatch swallows error

    Brian Vaughn committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    3df17ba View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2018

  1. Changed componentDidCatch state-update detection logic based on feedb… 

    …ack from Andrew
    Brian Vaughn committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    233459a View commit details
    Browse the repository at this point in the history

  2. Updated a few tests to account for a new DEV warning

    Brian Vaughn committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    9943c6c View commit details
    Browse the repository at this point in the history

  3. Changed componentDidCatch no-state-update warning message to remove m… 

    …ention of throw

I think this is confusing because it implies that gDSFE can throw and cDC will still be called, when that is not the case (because cDC is a commit phase lifecycle- and if gDSFE rethrows, the boundary in question will never mount and the commit phase menthods it defines will not be called.
    Brian Vaughn committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    54f637f View commit details
    Browse the repository at this point in the history

  4. Force remount children by reconciling against an empty set

    @acdlite
    acdlite committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    574f68e View commit details
    Browse the repository at this point in the history

  5. Add incremental error test

    @acdlite
    acdlite committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    f1171b7 View commit details
    Browse the repository at this point in the history