Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a crash when using dynamic children in <option> tag #13261

Merged
merged 10 commits into from
Aug 1, 2018
Merged

Fix a crash when using dynamic children in <option> tag #13261

merged 10 commits into from
Aug 1, 2018

Commits on Jul 24, 2018

  1. Make option children a text content by default 

    fix facebook#11911
    @Slowyn
    Slowyn committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    388028e View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2018

  1. Apply requested changes 

    - Remove meaningless comments
- revert scripts/rollup/results.json
    @Slowyn
    Slowyn committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    f829340 View commit details
    Browse the repository at this point in the history

  2. remove empty row

    @Slowyn
    Slowyn committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    73697ef View commit details
    Browse the repository at this point in the history

  3. Update comment

    @Slowyn
    Slowyn committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    65691b6 View commit details
    Browse the repository at this point in the history

  4. Add a simple unit-test

    @Slowyn
    Slowyn committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    9ca2085 View commit details
    Browse the repository at this point in the history

  5. [WIP: no flow] Pass through hostContext

    @Slowyn
    Slowyn committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    931417b View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2018

  1. [WIP: no flow] Give better description for test

    @Slowyn
    Slowyn committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    485d8db View commit details
    Browse the repository at this point in the history

  2. Fixes

    @gaearon
    gaearon committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    a6a8d1c View commit details
    Browse the repository at this point in the history

  3. Don't pass hostContext through 

    It ended up being more complicated than I thought.
    @gaearon
    gaearon committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    7ccf3ce View commit details
    Browse the repository at this point in the history

  4. Also warn on hydration

    @gaearon
    gaearon committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    e614dbf View commit details
    Browse the repository at this point in the history