Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transitive dependency on fbjs #13075

Merged
merged 1 commit into from Jun 19, 2018
Merged

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jun 19, 2018

This bumps to include facebook/prop-types#194, making it possible to remove even transitive deps on fbjs in the next release.

@pull-bot
Copy link

Details of bundled changes.

Comparing: aeda7b7...0e412f3

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js -5.7% -5.6% 60.25 KB 56.81 KB 16.77 KB 15.82 KB UMD_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.5% -0.7% 626.74 KB 623.3 KB 146.62 KB 145.64 KB UMD_DEV
react-dom-server.browser.development.js -3.4% -1.2% 102.64 KB 99.19 KB 26.53 KB 26.21 KB UMD_DEV

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js -0.8% -1.0% 411.02 KB 407.58 KB 92.16 KB 91.21 KB UMD_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js -1.0% -0.5% 345.26 KB 341.82 KB 74.38 KB 74.02 KB UMD_DEV
react-test-renderer-shallow.development.js -13.7% -9.4% 25.08 KB 21.64 KB 6.52 KB 5.9 KB UMD_DEV

Generated by 🚫 dangerJS

@gaearon
Copy link
Collaborator Author

gaearon commented Jun 19, 2018

Meh should be fine

@gaearon gaearon merged commit 8e87c13 into facebook:master Jun 19, 2018
@gaearon gaearon deleted the bump-pt branch June 19, 2018 16:52
NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants