Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t error when returning an empty Fragment #12966

Merged
merged 4 commits into from Jun 11, 2018
Merged

Don’t error when returning an empty Fragment #12966

merged 4 commits into from Jun 11, 2018

Commits on Jun 2, 2018

  1. Don’t error when returning an empty Fragment 

    When a fragment is reconciled, we directly move onto it’s children.
Since an empty `<React.Fragment/>` will have children of `undefined`,
this would always throw.

To fix this, we bail out in those cases.
    @philipp-spiess
    philipp-spiess committed Jun 2, 2018
    Copy the full SHA
    931bc7d View commit details
    Browse the repository at this point in the history

  2. Test the update path as well

    @philipp-spiess
    philipp-spiess committed Jun 2, 2018
    Copy the full SHA
    4de2539 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2018

  1. Reuse existing code path

    @gaearon
    gaearon committed Jun 11, 2018
    Copy the full SHA
    697bd71 View commit details
    Browse the repository at this point in the history

  2. An even more explicit solution that also fixes Flow

    @gaearon
    gaearon committed Jun 11, 2018
    Copy the full SHA
    6d8c3f5 View commit details
    Browse the repository at this point in the history