Fix issue 12939 #12954
Fix issue 12939 #12954
Conversation
The input range didn't receive a correct value. e.g. For, <input type="range" min="0" max="10" value="0" />, the value will be set to 10 in react. Setting hostProps' value to '', which happened to be before before everything i.e. before the value tracker initialize fix the whole problem
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
| "size": 210769, | ||
| "gzip": 36828 | ||
| "size": 210616, | ||
| "gzip": 36800 |
There was a problem hiding this comment.
Please revert changes to this file
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks, but this is already being worked on in #12939 |
This fix only broke one test, which I think is acceptable
react/packages/react-dom/src/__tests__/ReactDOMInput-test.js
Line 1296 in 15767a8
The demo is here
https://whs-dot-hk.github.io/react-bug-12926-test/