Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not assign node.value on input creation if no change will occur #12925

Merged
merged 1 commit into from May 29, 2018
Merged

Do not assign node.value on input creation if no change will occur #12925

merged 1 commit into from May 29, 2018

Commits on May 29, 2018

  1. Do not assign node.value on input creation if no change will occur 

    This commit fixes an issue where assigning an empty string to required
text inputs triggers the invalid state in Firefox (~60.0.1).

It does this by first comparing the initial state value to the current
value property on the text element. This:

1. Prevents the validation issue
2. Avoids an extra DOM Mutation in some cases
    @nhunzaker
    nhunzaker committed May 29, 2018
    Copy the full SHA
    b7c136d View commit details
    Browse the repository at this point in the history