Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend input type check in selection capabilities (#12062) #12135

Merged
merged 3 commits into from May 30, 2018
Merged

Extend input type check in selection capabilities (#12062) #12135

merged 3 commits into from May 30, 2018
+71 −2

Commits on Apr 12, 2018

  1. Do not set selection when prior selection is undefined (facebook#12062) 

    `restoreSelection` did not account for input elements that have changed
type after the commit phase. The new `text` input supported selection
but the old `email` did not and `setSelection` was incorrectly trying to
restore `null` selection state.

We also extend input type check in selection capabilities to cover cases
where input type is `search`, `tel`, `url`, or `password`.
    @spirosikmd
    spirosikmd committed Apr 12, 2018
    Copy the full SHA
    7ec68da View commit details
    Browse the repository at this point in the history

  2. Add link to HTML spec for element types and selection

    @spirosikmd
    spirosikmd committed Apr 12, 2018
    Copy the full SHA
    a96034f View commit details
    Browse the repository at this point in the history

Commits on May 30, 2018

  1. Add reset button to ReplaceEmailInput 

    This commit adds a button to restore the original state of the
ReplaceEmailInput fixture so that it can be run multiple times without
refreshing the page.
    @nhunzaker
    nhunzaker committed May 30, 2018
    Copy the full SHA
    3425970 View commit details
    Browse the repository at this point in the history