Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15.6.3 dev #11575

Closed
wants to merge 2 commits into from
Closed

15.6.3 dev #11575

wants to merge 2 commits into from

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Nov 16, 2017

No description provided.

@nhunzaker
Copy link
Contributor 

$ ./node_modules/.bin/grunt build
Loading "Gruntfile.js" tasks...ERROR
>> Error: Cannot find module 'events/'

From the CI build. Is this addressable at all?

nhunzaker
nhunzaker approved these changes Nov 17, 2017
View reviewed changes
Copy link
Contributor

@nhunzaker nhunzaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming we can sort out what's going on with CI.

@jquense
Copy link
Contributor Author

jquense commented Nov 27, 2017

sorry i can't figure out what the deal with CI is here...

@bvaughn
RFC 6: createReactClass updates (#12036)
5530c75 
* Added UNSAFE_ methods to create-class HAS_MANY list
* Added warning for UNSAFE_componentWillRecieveProps misspelling
* Bumping create-react-class package version
* Added support for static getDerivedStateFromProps mixins
@nhunzaker
Copy link
Contributor

Closing this out, since it's associated with #11573. We landed on not sending out a release.

@nhunzaker nhunzaker closed this Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhunzaker nhunzaker nhunzaker approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jquense @nhunzaker @facebook-github-bot @bvaughn