New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Stack reconciler #10517
Closed
Closed
Delete Stack reconciler #10517
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c48f532
Remove Fiber Jest project
gaearon 3c0a379
Remove Stack reconciler and ReactDOMStack code
gaearon f4b010c
Fix tests depending on Stack internals
gaearon 9a261c7
Remove Stack-only DEV code
gaearon eea00f7
Fix lint
gaearon 19ff9dc
Fix Flow
gaearon 227f6db
Remove usage of ReactDOMFeatureFlags.useFiber, assuming true
gaearon d091292
Remove findDOMNode injection and inline it
gaearon 2148c01
Remove Stack-only code in ReactGenericBatching
gaearon e868e1c
Remove Stack-only code branches
gaearon 93b1e9a
Remvoe undocumented TestUtils methods that are broken in Fiber
gaearon 1dcaed7
Fix newly added test from master
gaearon 4a2d836
Record sizes
gaearon File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried keeping just one project but even the newest version of Jest (21 alpha) crashes with just one project so I had to inline the config back. cc @cpojer in case this is not known.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, it's a known issue you already filed jestjs/jest#4117 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, thanks. I remember a few issues were recently closed so I wasn't sure. Sorry I didn't check 😛