Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-react-class cannot be compiled with latest Google Closure Compiler #9750

Closed
elijahsmith opened this issue May 23, 2017 · 4 comments
Closed

Comments

@elijahsmith
Copy link

elijahsmith commented May 23, 2017

When trying to compile create-react-class 15.3.1 with the latest Closure Compiler, the compiler complains:

react.js:4782: ERROR - @nosideeffects may only appear in externs files.
  render: SpecPolicy.DEFINE_ONCE,

This is related to #7551. The create-react-class npm package needs to be republished with the React 15.5.4 code.

This ticket is spun off of #7551 (comment).

@elijahsmith
Copy link
Author

we are blocked on this issue (our build system relies on the Closure Compiler, and some of our dependencies use create-react-class). Is there anything I can do to help this process forward?

@gaearon
Copy link
Collaborator

gaearon commented Jun 12, 2017

This is fixed in #9933 and will be out with next release.

@gaearon gaearon closed this as completed Jun 12, 2017
@elijahsmith
Copy link
Author

this change is not in 15.6.0 nor the latest build of the create-react-class npm package

https://github.com/facebook/react/blob/v15.6.0/addons/create-react-class/factory.js#L163

do we need to wait for 15.6.1?

@gaearon
Copy link
Collaborator

gaearon commented Jun 14, 2017

See my comment in #7551 (comment).

It is in the 15.6.0 RC of addons (it will be released separately today).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants