[babel-plugin-react-jsx] Avoid duplicate "children" key in props obje…

…ct (#17094) * [babel-plugin-react-jsx] Avoid duplicate "children" key in props object * Use Object.assign approach
facebook · Oct 15, 2019 · e7704e2 · e7704e2
1 parent fdba0e5
commit e7704e2
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 1 deletion.
diff --git a/packages/babel-plugin-react-jsx/__tests__/TransformJSXToReactJSX-test.js b/packages/babel-plugin-react-jsx/__tests__/TransformJSXToReactJSX-test.js
@@ -480,4 +480,10 @@ describe('transform react to jsx', () => {
       transform(`<Component y={2} {...x} />`, {useBuiltIns: false})
     ).toMatchSnapshot();
   });
+
+  it('should not contain duplicate children key in props object', () => {
+    expect(
+      transform(`<Component children={1}>2</Component>`)
+    ).toMatchSnapshot();
+  });
 });
diff --git a/packages/babel-plugin-react-jsx/__tests__/__snapshots__/TransformJSXToReactJSX-test.js.snap b/packages/babel-plugin-react-jsx/__tests__/__snapshots__/TransformJSXToReactJSX-test.js.snap
@@ -250,6 +250,14 @@ var e = React.jsx(F, {
 });
 `;
 
+exports[`transform react to jsx should not contain duplicate children key in props object 1`] = `
+React.jsx(Component, Object.assign({
+  children: 1
+}, {
+  children: "2"
+}));
+`;
+
 exports[`transform react to jsx should not strip nbsp even couple with other whitespace 1`] = `
 React.jsx("div", {
   children: "\\xA0 "

diff --git a/packages/babel-plugin-react-jsx/src/TransformJSXToReactBabelPlugin.js b/packages/babel-plugin-react-jsx/src/TransformJSXToReactBabelPlugin.js
@@ -268,11 +268,20 @@ You can turn on the 'throwIfNamespace' flag to bypass this warning.`,
     );
   }
 
+  function isChildrenProp(prop) {
+    return (
+      t.isJSXAttribute(prop) &&
+      t.isJSXIdentifier(prop.name) &&
+      prop.name.name === 'children'
+    );
+  }
+
   // Builds props for React.jsx. This function adds children into the props
   // and ensures that props is always an object
   function buildJSXOpeningElementAttributes(attribs, file, children) {
     let _props = [];
     const objs = [];
+    const hasChildren = children && children.length > 0;
 
     const useBuiltIns = file.opts.useBuiltIns || false;
     if (typeof useBuiltIns !== 'boolean') {
@@ -287,14 +296,22 @@ You can turn on the 'throwIfNamespace' flag to bypass this warning.`,
       if (t.isJSXSpreadAttribute(prop)) {
         _props = pushProps(_props, objs);
         objs.push(prop.argument);
+      } else if (hasChildren && isChildrenProp(prop)) {
+        // In order to avoid having duplicate "children" keys, we avoid
+        // pushing the "children" prop if we have actual children. Instead
+        // we put the children into a separate object and then rely on
+        // the Object.assign logic below to ensure the correct object is
+        // formed.
+        _props = pushProps(_props, objs);
+        objs.push(t.objectExpression([convertAttribute(prop)]));
       } else {
         _props.push(convertAttribute(prop));
       }
     }
 
     // In React.JSX, children is no longer a separate argument, but passed in
     // through the argument object
-    if (children && children.length > 0) {
+    if (hasChildren) {
       if (children.length === 1) {
         _props.push(t.objectProperty(t.identifier('children'), children[0]));
       } else {