Remove concurrent APIs from stable builds

Those who want to try concurrent mode should use the experimental builds instead. I've left the `unstable_` prefixed APIs in the Facebook build so we can continue experimenting with them internally without blessing them for widespread use.
facebook · Oct 14, 2019 · 80a1a43 · 80a1a43
1 parent a8c6a1b
commit 80a1a43
Show file tree

Hide file tree

Showing 27 changed files with 1,663 additions and 1,585 deletions.
diff --git a/packages/react-dom/src/__tests__/ReactDOMFiberAsync-test.internal.js b/packages/react-dom/src/__tests__/ReactDOMFiberAsync-test.internal.js
diff --git a/packages/react-dom/src/__tests__/ReactDOMHooks-test.js b/packages/react-dom/src/__tests__/ReactDOMHooks-test.js
@@ -105,38 +105,40 @@ describe('ReactDOMHooks', () => {
     expect(labelRef.current.innerHTML).toBe('abc');
   });
 
-  it('should not bail out when an update is scheduled from within an event handler in Concurrent Mode', () => {
-    const {createRef, useCallback, useState} = React;
-
-    const Example = ({inputRef, labelRef}) => {
-      const [text, setText] = useState('');
-      const handleInput = useCallback(event => {
-        setText(event.target.value);
-      });
-
-      return (
-        <>
-          <input ref={inputRef} onInput={handleInput} />
-          <label ref={labelRef}>{text}</label>
-        </>
+  if (__EXPERIMENTAL__) {
+    it('should not bail out when an update is scheduled from within an event handler in Concurrent Mode', () => {
+      const {createRef, useCallback, useState} = React;
+
+      const Example = ({inputRef, labelRef}) => {
+        const [text, setText] = useState('');
+        const handleInput = useCallback(event => {
+          setText(event.target.value);
+        });
+
+        return (
+          <>
+            <input ref={inputRef} onInput={handleInput} />
+            <label ref={labelRef}>{text}</label>
+          </>
+        );
+      };
+
+      const inputRef = createRef();
+      const labelRef = createRef();
+
+      const root = ReactDOM.createRoot(container);
+      root.render(<Example inputRef={inputRef} labelRef={labelRef} />);
+
+      Scheduler.unstable_flushAll();
+
+      inputRef.current.value = 'abc';
+      inputRef.current.dispatchEvent(
+        new Event('input', {bubbles: true, cancelable: true}),
       );
-    };
 
-    const inputRef = createRef();
-    const labelRef = createRef();
-
-    const root = ReactDOM.unstable_createRoot(container);
-    root.render(<Example inputRef={inputRef} labelRef={labelRef} />);
-
-    Scheduler.unstable_flushAll();
-
-    inputRef.current.value = 'abc';
-    inputRef.current.dispatchEvent(
-      new Event('input', {bubbles: true, cancelable: true}),
-    );
+      Scheduler.unstable_flushAll();
 
-    Scheduler.unstable_flushAll();
-
-    expect(labelRef.current.innerHTML).toBe('abc');
-  });
+      expect(labelRef.current.innerHTML).toBe('abc');
+    });
+  }
 });
diff --git a/packages/react-dom/src/__tests__/ReactDOMRoot-test.js b/packages/react-dom/src/__tests__/ReactDOMRoot-test.js
@@ -26,15 +26,22 @@ describe('ReactDOMRoot', () => {
     Scheduler = require('scheduler');
   });
 
+  if (!__EXPERIMENTAL__) {
+    it('createRoot is not exposed in stable build', () => {
+      expect(ReactDOM.createRoot).toBe(undefined);
+    });
+    return;
+  }
+
   it('renders children', () => {
-    const root = ReactDOM.unstable_createRoot(container);
+    const root = ReactDOM.createRoot(container);
     root.render(<div>Hi</div>);
     Scheduler.unstable_flushAll();
     expect(container.textContent).toEqual('Hi');
   });
 
   it('unmounts children', () => {
-    const root = ReactDOM.unstable_createRoot(container);
+    const root = ReactDOM.createRoot(container);
     root.render(<div>Hi</div>);
     Scheduler.unstable_flushAll();
     expect(container.textContent).toEqual('Hi');
@@ -57,7 +64,7 @@ describe('ReactDOMRoot', () => {
     // Does not hydrate by default
     const container1 = document.createElement('div');
     container1.innerHTML = markup;
-    const root1 = ReactDOM.unstable_createRoot(container1);
+    const root1 = ReactDOM.createRoot(container1);
     root1.render(
       <div>
         <span />
@@ -68,7 +75,7 @@ describe('ReactDOMRoot', () => {
     // Accepts `hydrate` option
     const container2 = document.createElement('div');
     container2.innerHTML = markup;
-    const root2 = ReactDOM.unstable_createRoot(container2, {hydrate: true});
+    const root2 = ReactDOM.createRoot(container2, {hydrate: true});
     root2.render(
       <div>
         <span />
@@ -81,7 +88,7 @@ describe('ReactDOMRoot', () => {
 
   it('does not clear existing children', async () => {
     container.innerHTML = '<div>a</div><div>b</div>';
-    const root = ReactDOM.unstable_createRoot(container);
+    const root = ReactDOM.createRoot(container);
     root.render(
       <div>
         <span>c</span>
@@ -102,12 +109,12 @@ describe('ReactDOMRoot', () => {
 
   it('throws a good message on invalid containers', () => {
     expect(() => {
-      ReactDOM.unstable_createRoot(<div>Hi</div>);
+      ReactDOM.createRoot(<div>Hi</div>);
     }).toThrow('createRoot(...): Target container is not a DOM element.');
   });
 
   it('warns when rendering with legacy API into createRoot() container', () => {
-    const root = ReactDOM.unstable_createRoot(container);
+    const root = ReactDOM.createRoot(container);
     root.render(<div>Hi</div>);
     Scheduler.unstable_flushAll();
     expect(container.textContent).toEqual('Hi');
@@ -130,7 +137,7 @@ describe('ReactDOMRoot', () => {
   });
 
   it('warns when hydrating with legacy API into createRoot() container', () => {
-    const root = ReactDOM.unstable_createRoot(container);
+    const root = ReactDOM.createRoot(container);
     root.render(<div>Hi</div>);
     Scheduler.unstable_flushAll();
     expect(container.textContent).toEqual('Hi');
@@ -150,7 +157,7 @@ describe('ReactDOMRoot', () => {
   });
 
   it('warns when unmounting with legacy API (no previous content)', () => {
-    const root = ReactDOM.unstable_createRoot(container);
+    const root = ReactDOM.createRoot(container);
     root.render(<div>Hi</div>);
     Scheduler.unstable_flushAll();
     expect(container.textContent).toEqual('Hi');
@@ -179,7 +186,7 @@ describe('ReactDOMRoot', () => {
     // Currently createRoot().render() doesn't clear this.
     container.appendChild(document.createElement('div'));
     // The rest is the same as test above.
-    const root = ReactDOM.unstable_createRoot(container);
+    const root = ReactDOM.createRoot(container);
     root.render(<div>Hi</div>);
     Scheduler.unstable_flushAll();
     expect(container.textContent).toEqual('Hi');
@@ -198,7 +205,7 @@ describe('ReactDOMRoot', () => {
   it('warns when passing legacy container to createRoot()', () => {
     ReactDOM.render(<div>Hi</div>, container);
     expect(() => {
-      ReactDOM.unstable_createRoot(container);
+      ReactDOM.createRoot(container);
     }).toWarnDev(
       'You are calling ReactDOM.createRoot() on a container that was previously ' +
         'passed to ReactDOM.render(). This is not supported.',